Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-error thrown in getStaticPaths shows correctly #33753

Merged
merged 1 commit into from Jan 27, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 27, 2022

This ensures if a string error throw 'invalid API token' is thrown inside of getStaticPaths that we properly show the error instead of showing an unrelated non-default React component export warning.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: slack thread

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member Author

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
buildDuration 17.8s 17.7s -120ms
buildDurationCached 4.4s 4.5s ⚠️ +77ms
nodeModulesSize 358 MB 358 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
/ failed reqs 0 0
/ total time (seconds) 4.341 4.437 ⚠️ +0.1
/ avg req/sec 575.85 563.44 ⚠️ -12.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.239 2.256 ⚠️ +0.02
/error-in-render avg req/sec 1116.38 1108.24 ⚠️ -8.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
buildDuration 22.8s 22.1s -689ms
buildDurationCached 4.4s 4.5s ⚠️ +164ms
nodeModulesSize 358 MB 358 MB -7 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
/ failed reqs 0 0
/ total time (seconds) 4.275 4.319 ⚠️ +0.04
/ avg req/sec 584.74 578.87 ⚠️ -5.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.243 2.228 -0.01
/error-in-render avg req/sec 1114.35 1122.11 +7.76
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/invalid-static-paths-error Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 0b13254

@ijjk ijjk merged commit 6aef15d into vercel:canary Jan 27, 2022
@ijjk ijjk deleted the fix/invalid-static-paths-error branch January 27, 2022 22:31
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants