Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all CSS files are included for experimental critical CSS #33752

Merged
merged 3 commits into from Jan 27, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 27, 2022

This fixes the case where not all CSS files were included in our required files manifest so they weren't able to be leveraged for the experimental critical CSS optimization in standalone environments.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #29925

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 27, 2022
@ijjk ijjk marked this pull request as ready for review January 27, 2022 21:39
@ijjk
Copy link
Member Author

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
buildDuration 12.6s 12.6s ⚠️ +3ms
buildDurationCached 3.2s 3.2s ⚠️ +17ms
nodeModulesSize 358 MB 358 MB -169 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
/ failed reqs 0 0
/ total time (seconds) 2.94 2.949 ⚠️ +0.01
/ avg req/sec 850.44 847.74 ⚠️ -2.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.401 1.43 ⚠️ +0.03
/error-in-render avg req/sec 1784.19 1748.39 ⚠️ -35.8
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
buildDuration 16.3s 15.9s -378ms
buildDurationCached 3.2s 3.2s ⚠️ +58ms
nodeModulesSize 358 MB 358 MB -169 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
/ failed reqs 0 0
/ total time (seconds) 2.92 2.934 ⚠️ +0.01
/ avg req/sec 856.28 852 ⚠️ -4.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.377 1.382 0
/error-in-render avg req/sec 1816.2 1809.13 ⚠️ -7.07
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/missing-critical-css Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 0ac5045

@ijjk ijjk merged commit 7ec49be into vercel:canary Jan 27, 2022
@ijjk ijjk deleted the fix/missing-critical-css branch January 27, 2022 22:22
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
…el#33752)

* Ensure all CSS files are included for experimental critical CSS

* remove extra import
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental OptimizeCss flag (critters) isn't deferring all css files properly.
2 participants