Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rsc test suite runner #33745

Merged
merged 1 commit into from Jan 27, 2022
Merged

fix rsc test suite runner #33745

merged 1 commit into from Jan 27, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 27, 2022

should run prod suite instead when env == prod...

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Jan 27, 2022
@ijjk
Copy link
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-test-suite Change
buildDuration 17.4s 17.3s -156ms
buildDurationCached 4.3s 4.5s ⚠️ +163ms
nodeModulesSize 358 MB 358 MB ⚠️ +15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-test-suite Change
/ failed reqs 0 0
/ total time (seconds) 4.178 4.273 ⚠️ +0.09
/ avg req/sec 598.33 585.09 ⚠️ -13.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.21 2.195 -0.02
/error-in-render avg req/sec 1131.22 1138.96 +7.74
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-test-suite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-test-suite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-test-suite Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-test-suite Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-test-suite Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-test-suite Change
buildDuration 21.7s 22.1s ⚠️ +338ms
buildDurationCached 4.3s 4.4s ⚠️ +126ms
nodeModulesSize 358 MB 358 MB ⚠️ +15 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix-test-suite Change
/ failed reqs 0 0
/ total time (seconds) 4.285 4.199 -0.09
/ avg req/sec 583.39 595.42 +12.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.199 2.185 -0.01
/error-in-render avg req/sec 1136.91 1144.33 +7.42
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-test-suite Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-test-suite Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-test-suite Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-test-suite Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-test-suite Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: ea77cb8

@huozhi huozhi merged commit eea3adc into vercel:canary Jan 27, 2022
@huozhi huozhi deleted the fix-test-suite branch January 27, 2022 19:51
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants