Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale-while-revalidate pattern to Image Optimization API #33735

Merged
merged 8 commits into from Jan 27, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 27, 2022

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 27, 2022
@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as ready for review January 27, 2022 16:27
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ijjk
Copy link
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
buildDuration 11.9s 11.8s -96ms
buildDurationCached 3.1s 3.1s ⚠️ +12ms
nodeModulesSize 358 MB 358 MB ⚠️ +803 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
/ failed reqs 0 0
/ total time (seconds) 2.725 2.769 ⚠️ +0.04
/ avg req/sec 917.48 902.78 ⚠️ -14.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.185 1.17 -0.02
/error-in-render avg req/sec 2108.97 2137.31 +28.34
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
buildDuration 15.5s 15.4s -97ms
buildDurationCached 3.1s 3.1s -11ms
nodeModulesSize 358 MB 358 MB ⚠️ +803 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
/ failed reqs 0 0
/ total time (seconds) 2.739 2.719 -0.02
/ avg req/sec 912.83 919.45 +6.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.165 1.173 ⚠️ +0.01
/error-in-render avg req/sec 2146 2131.83 ⚠️ -14.17
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-stale-while-revalidate-images Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: c42a8bf

@kodiakhq kodiakhq bot merged commit 16b5bfa into canary Jan 27, 2022
@kodiakhq kodiakhq bot deleted the add-stale-while-revalidate-images branch January 27, 2022 21:33
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Optimization should use the stale-while-revalidate pattern
2 participants