Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next-swc): Update swc #33724

Merged
merged 5 commits into from Feb 3, 2022
Merged

feat(next-swc): Update swc #33724

merged 5 commits into from Feb 3, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 27, 2022 •
edited

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 27, 2022
@ijjk

This comment has been minimized.

Sign in to view
@kdy1 kdy1 marked this pull request as ready for review January 28, 2022 04:46
@ijjk

This comment has been minimized.

Sign in to view
@kdy1 kdy1 requested a review from padmaia as a code owner February 3, 2022 07:45
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 3, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-11 Change
buildDuration 14.4s 14.8s ⚠️ +372ms
buildDurationCached 3.7s 3.8s ⚠️ +48ms
nodeModulesSize 359 MB 359 MB ⚠️ +108 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-11 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.506 3.431 -0.07
/ avg req/sec 713.14 728.75 +15.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.627 1.659 ⚠️ +0.03
/error-in-render avg req/sec 1536.35 1507.09 ⚠️ -29.26
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-11 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.2 kB 71.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-11 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-11 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-11 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-11 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-11 Change
buildDuration 18.9s 18.1s -863ms
buildDurationCached 3.9s 3.7s -210ms
nodeModulesSize 359 MB 359 MB ⚠️ +108 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-11 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.575 3.553 -0.02
/ avg req/sec 699.35 703.67 +4.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.663 1.65 -0.01
/error-in-render avg req/sec 1503.14 1514.7 +11.56
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-11 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.4 kB 27.4 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-11 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-11 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-11 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-11 Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 0676bbe

@kodiakhq kodiakhq bot merged commit 4bd76ff into vercel:canary Feb 3, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@kdy1 @natew
feat(next-swc): Update swc (vercel#33724)
b0a8472 
This PR applies

 - swc-project/swc#3350

which fixes lots of minifier issues.

 - swc-project/swc#3391

This fixes the regression of evaluatior.

 - swc-project/swc#3436

This fixes codegen bugs.

 - swc-project/swc#3425

This improves compression.

 - swc-project/swc#3400

This fixes some transform bugs.

 - swc-project/swc#3392
 
This implements more terser options.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
@kdy1 kdy1 deleted the swc-up-11 branch March 30, 2022 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@padmaia padmaia padmaia approved these changes

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ijjk @padmaia