Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use github action instead of bot #33718

Merged
merged 5 commits into from Jan 27, 2022
Merged

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jan 27, 2022

The current workflow did not actually work anymore, since the bot was deprecated, and migration has been advised: dessant/lock-threads#30

This action will run hourly to scan for inactive closed issues/PRs. (There are many, so running it hourly is reasonable)

This PR also increases the operations allowed for the Stale action. from 30 to 300. That should cover all of our issues/PRs currently.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/update-lock-action Change
buildDuration 12.7s 12.6s -93ms
buildDurationCached 3.4s 3.4s -29ms
nodeModulesSize 356 MB 356 MB ⚠️ +10 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/update-lock-action Change
/ failed reqs 0 0
/ total time (seconds) 2.946 2.919 -0.03
/ avg req/sec 848.49 856.57 +8.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.371 1.38 ⚠️ +0.01
/error-in-render avg req/sec 1823.92 1811.7 ⚠️ -12.22
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/update-lock-action Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/update-lock-action Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/update-lock-action Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/update-lock-action Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/update-lock-action Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/update-lock-action Change
buildDuration 16.2s 16.4s ⚠️ +231ms
buildDurationCached 3.4s 3.4s ⚠️ +17ms
nodeModulesSize 356 MB 356 MB ⚠️ +10 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/update-lock-action Change
/ failed reqs 0 0
/ total time (seconds) 2.913 2.958 ⚠️ +0.05
/ avg req/sec 858.23 845.21 ⚠️ -13.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.379 1.385 ⚠️ +0.01
/error-in-render avg req/sec 1813.3 1805.17 ⚠️ -8.13
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/update-lock-action Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/update-lock-action Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/update-lock-action Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/update-lock-action Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/update-lock-action Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: a9c6bbb

.github/workflows/lock.yml Outdated Show resolved Hide resolved
@balazsorban44 balazsorban44 merged commit 4916aa1 into canary Jan 27, 2022
@balazsorban44 balazsorban44 deleted the fix/update-lock-action branch January 27, 2022 00:51
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* fix: use github action instead of bot

* add personal access tokens to avoid rate limiting

* Update .github/workflows/lock.yml

Co-authored-by: Steven <steven@ceriously.com>

* add cron comments

Co-authored-by: Steven <steven@ceriously.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants