Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swc parse for flight server and client loaders #33713

Merged
merged 16 commits into from Jan 27, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 26, 2022

  • Add parse method for next-swc
  • Use shared next-swc to parse rsc components AST
  • Remove the invalid case of parsing ExportAllDecalaration (we didn't support it well before, so I deleted. need to support later)

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 26, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review January 26, 2022 23:38
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why are webpack and terser affected in this change?

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flight loader related changes look great to me, cc @kdy1 for swc related code.

@huozhi
Copy link
Member Author

huozhi commented Jan 26, 2022

Just curious, why are webpack and terser affected in this change?

@shuding Seems when I removed acorn it effects webpack and terser since they're depending on it

@huozhi
Copy link
Member Author

huozhi commented Jan 26, 2022

@ijjk most tests are passed but JJ bot doesn't hide them :wat2:

@ijjk

This comment has been minimized.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some perf issues, mainly because parse did not get enough attention.

packages/next-swc/crates/napi/src/parse.rs Outdated Show resolved Hide resolved
packages/next-swc/crates/napi/src/parse.rs Outdated Show resolved Hide resolved
packages/next-swc/crates/napi/src/parse.rs Outdated Show resolved Hide resolved
packages/next/build/swc/index.js Outdated Show resolved Hide resolved
packages/next-swc/crates/napi/src/parse.rs Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 27, 2022

Failing test suites

Commit: cb16b6a

test/integration/ondemand/test/index.test.js

  • On Demand Entries > should navigate to pages with dynamic imports
Expand output

● On Demand Entries › should navigate to pages with dynamic imports

TIMED OUT: /Hello/

/nav/dynamic

  479 | }
  480 |
> 481 | export class File {
      |               ^
  482 |   constructor(path) {
  483 |     this.path = path
  484 |     this.originalContent = existsSync(this.path)

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (integration/ondemand/test/index.test.js:102:13)

@huozhi huozhi requested review from kdy1 and shuding January 27, 2022 11:30
kdy1
kdy1 previously approved these changes Jan 27, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust codes and codes for binding looks good to me

shuding
shuding previously approved these changes Jan 27, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi dismissed stale reviews from shuding and kdy1 via 0d271b0 January 27, 2022 14:21
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js swc-parse Change
buildDuration 12s 11.9s -7ms
buildDurationCached 3.1s 3.1s ⚠️ +21ms
nodeModulesSize 358 MB 358 MB -1.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js swc-parse Change
/ failed reqs 0 0
/ total time (seconds) 2.743 2.709 -0.03
/ avg req/sec 911.57 922.74 +11.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.181 1.171 -0.01
/error-in-render avg req/sec 2116.86 2135.66 +18.8
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js swc-parse Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js swc-parse Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js swc-parse Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js swc-parse Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js swc-parse Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js swc-parse Change
buildDuration 15.6s 15.5s -86ms
buildDurationCached 3.1s 3.1s -4ms
nodeModulesSize 358 MB 358 MB -1.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js swc-parse Change
/ failed reqs 0 0
/ total time (seconds) 2.742 2.713 -0.03
/ avg req/sec 911.62 921.63 +10.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.177 1.156 -0.02
/error-in-render avg req/sec 2124.15 2161.71 +37.56
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js swc-parse Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js swc-parse Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js swc-parse Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js swc-parse Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js swc-parse Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: fdea40d

@kodiakhq kodiakhq bot merged commit 3bda6e6 into vercel:canary Jan 27, 2022
@huozhi huozhi deleted the swc-parse branch January 27, 2022 15:52
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* Add `parse` method for next-swc
* Use shared next-swc to parse rsc components AST
* Remove the invalid case of parsing `ExportAllDecalaration` (we didn't support it well before, so I deleted. need to support later)


Co-authored-by: Donny/강동윤 <29931815+kdy1@users.noreply.github.com>
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants