Fix with-docker example dockerfile
#33695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystxf
requested review from
ijjk,
leerob,
shuding,
steven-tey and
timneutkens
as code owners
leerob
reviewed
Jan 26, 2022
leerob
reviewed
Jan 26, 2022
ijjk
reviewed
Jan 26, 2022
Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
reviewed
Jan 27, 2022
ijjk
approved these changes
Jan 27, 2022
|
Shouldn’t this be suggesting to use “npm ci” instead of “npm install”? It’s supposed to be better for running in CI/CD? |
1 task
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
Fixed `dockerfile` in `with-docker` example ## Bug - error when executing `docker build -t nextjs-docker .` - `yarn.lock` file is missing ## Documentation / Examples - edited to not fail when `package-lock.json` or `yarn.lock` are not found - example: use `with-docker` example - [x] Make sure the linting passes by running yarn lint Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
dockerfileinwith-dockerexampleBug
docker build -t nextjs-docker .-yarn.lockfile is missingDocumentation / Examples
edited to not fail when
package-lock.jsonoryarn.lockare not foundexample: use
with-dockerexampleMake sure the linting passes by running yarn lint