fix: fixes #33314 move is-plain-object for es5 compilation #33690

PizzaPete · 2022-01-26T13:08:06Z

Bug

Related issues linked using fixes #33314 Client bundles contain non es5 code #33314
Moved the is-plain-object file to the shared directory since it's emitted to the client and thus needs to be transpiled.

This is just my 2nd PR so if I'm missing something please let me know.

PizzaPete · 2022-01-26T14:04:24Z

How can I re-trigger these tests? They seem to pass locally.

ijjk

Thanks for the PR!

ijjk · 2022-01-27T17:48:54Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	PizzaPete/next.js canary	Change
buildDuration	13.1s	12.8s	-346ms
buildDurationCached	3.3s	3.3s	-57ms
nodeModulesSize	358 MB	358 MB	⚠️ +19 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	PizzaPete/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.988	3.043	⚠️ +0.06
/ avg req/sec	836.74	821.62	⚠️ -15.12
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.421	1.436	⚠️ +0.01
/error-in-render avg req/sec	1759.27	1740.7	⚠️ -18.57

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	PizzaPete/next.js canary	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	⚠️ +10 B
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71 kB	71 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	PizzaPete/next.js canary	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	PizzaPete/next.js canary	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.94 kB	4.94 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.4 kB	14.4 kB	✓

Client Build Manifests

	vercel/next.js canary	PizzaPete/next.js canary	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	PizzaPete/next.js canary	Change
index.html gzip	531 B	532 B	⚠️ +1 B
link.html gzip	545 B	546 B	⚠️ +1 B
withRouter.html gzip	526 B	527 B	⚠️ +1 B
Overall change	1.6 kB	1.6 kB	⚠️ +3 B

Diffs

Diff for main-HASH.js

@@ -3876,6 +3876,28 @@
       /***/
     },
 
+    /***/ 8887: /***/ function(__unused_webpack_module, exports) {
+      "use strict";
+
+      Object.defineProperty(exports, "__esModule", {
+        value: true
+      });
+      exports.getObjectClassLabel = getObjectClassLabel;
+      exports.isPlainObject = isPlainObject;
+      function getObjectClassLabel(value) {
+        return Object.prototype.toString.call(value);
+      }
+      function isPlainObject(value) {
+        if (getObjectClassLabel(value) !== "[object Object]") {
+          return false;
+        }
+        var prototype = Object.getPrototypeOf(value);
+        return prototype === null || prototype === Object.prototype;
+      } //# sourceMappingURL=is-plain-object.js.map
+
+      /***/
+    },
+
     /***/ 5660: /***/ function(__unused_webpack_module, exports) {
       "use strict";
 
@@ -9062,7 +9084,7 @@
       });
       exports["default"] = isError;
       exports.getProperError = getProperError;
-      var _isPlainObject = __webpack_require__(2288);
+      var _isPlainObject = __webpack_require__(8887);
       function isError(err) {
         return (
           typeof err === "object" &&
@@ -9089,30 +9111,6 @@
       /***/
     },
 
-    /***/ 2288: /***/ function(__unused_webpack_module, exports) {
-      "use strict";
-
-      Object.defineProperty(exports, "__esModule", {
-        value: true
-      });
-      exports.getObjectClassLabel = getObjectClassLabel;
-      exports.isPlainObject = isPlainObject;
-      function getObjectClassLabel(value) {
-        return Object.prototype.toString.call(value);
-      }
-      function isPlainObject(value) {
-        if (getObjectClassLabel(value) !== "[object Object]") {
-          return false;
-        }
-        const prototype = Object.getPrototypeOf(value);
-        return prototype === null || prototype === Object.prototype;
-      }
-
-      //# sourceMappingURL=is-plain-object.js.map
-
-      /***/
-    },
-
     /***/ 4522: /***/ function(
       __unused_webpack_module,
       exports,

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-dda21bde619fccde.js"
+      src="/_next/static/chunks/main-2591fd5f83f97f60.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-dda21bde619fccde.js"
+      src="/_next/static/chunks/main-2591fd5f83f97f60.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-dda21bde619fccde.js"
+      src="/_next/static/chunks/main-2591fd5f83f97f60.js"
       defer=""
     ></script>
     <script

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	PizzaPete/next.js canary	Change
buildDuration	16.5s	16.2s	-277ms
buildDurationCached	3.4s	3.2s	-201ms
nodeModulesSize	358 MB	358 MB	⚠️ +19 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	PizzaPete/next.js canary	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.001	2.991	-0.01
/ avg req/sec	833.08	835.7	+2.62
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.414	1.4	-0.01
/error-in-render avg req/sec	1767.44	1786.2	+18.76

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	PizzaPete/next.js canary	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.3 kB	27.3 kB	⚠️ +8 B
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	⚠️ +8 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	PizzaPete/next.js canary	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	PizzaPete/next.js canary	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.97 kB	4.97 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.21 kB	2.21 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.3 kB	14.3 kB	✓

Client Build Manifests

	vercel/next.js canary	PizzaPete/next.js canary	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	PizzaPete/next.js canary	Change
index.html gzip	531 B	530 B	-1 B
link.html gzip	545 B	543 B	-2 B
withRouter.html gzip	526 B	525 B	-1 B
Overall change	1.6 kB	1.6 kB	-4 B

Diffs

Diff for main-HASH.js

@@ -3876,6 +3876,28 @@
       /***/
     },
 
+    /***/ 8887: /***/ function(__unused_webpack_module, exports) {
+      "use strict";
+
+      Object.defineProperty(exports, "__esModule", {
+        value: true
+      });
+      exports.getObjectClassLabel = getObjectClassLabel;
+      exports.isPlainObject = isPlainObject;
+      function getObjectClassLabel(value) {
+        return Object.prototype.toString.call(value);
+      }
+      function isPlainObject(value) {
+        if (getObjectClassLabel(value) !== "[object Object]") {
+          return false;
+        }
+        var prototype = Object.getPrototypeOf(value);
+        return prototype === null || prototype === Object.prototype;
+      } //# sourceMappingURL=is-plain-object.js.map
+
+      /***/
+    },
+
     /***/ 5660: /***/ function(__unused_webpack_module, exports) {
       "use strict";
 
@@ -9062,7 +9084,7 @@
       });
       exports["default"] = isError;
       exports.getProperError = getProperError;
-      var _isPlainObject = __webpack_require__(2288);
+      var _isPlainObject = __webpack_require__(8887);
       function isError(err) {
         return (
           typeof err === "object" &&
@@ -9089,30 +9111,6 @@
       /***/
     },
 
-    /***/ 2288: /***/ function(__unused_webpack_module, exports) {
-      "use strict";
-
-      Object.defineProperty(exports, "__esModule", {
-        value: true
-      });
-      exports.getObjectClassLabel = getObjectClassLabel;
-      exports.isPlainObject = isPlainObject;
-      function getObjectClassLabel(value) {
-        return Object.prototype.toString.call(value);
-      }
-      function isPlainObject(value) {
-        if (getObjectClassLabel(value) !== "[object Object]") {
-          return false;
-        }
-        const prototype = Object.getPrototypeOf(value);
-        return prototype === null || prototype === Object.prototype;
-      }
-
-      //# sourceMappingURL=is-plain-object.js.map
-
-      /***/
-    },
-
     /***/ 4522: /***/ function(
       __unused_webpack_module,
       exports,

Diff for index.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-dda21bde619fccde.js"
+      src="/_next/static/chunks/main-2591fd5f83f97f60.js"
       defer=""
     ></script>
     <script

Diff for link.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-dda21bde619fccde.js"
+      src="/_next/static/chunks/main-2591fd5f83f97f60.js"
       defer=""
     ></script>
     <script

Diff for withRouter.html

@@ -19,7 +19,7 @@
       defer=""
     ></script>
     <script
-      src="/_next/static/chunks/main-dda21bde619fccde.js"
+      src="/_next/static/chunks/main-2591fd5f83f97f60.js"
       defer=""
     ></script>
     <script

Commit: 3697168

…cel#33690) ## Bug - [ ] Related issues linked using `fixes vercel#33314` vercel#33314 - [ ] Moved the `is-plain-object` file to the shared directory since it's emitted to the client and thus needs to be transpiled. This is just my 2nd PR so if I'm missing something please let me know.

fix: move is-plain-object for es5 compilation

fe23c43

PizzaPete requested review from huozhi, ijjk, shuding and timneutkens as code owners January 26, 2022 13:08

ijjk added the type: next label Jan 26, 2022

Merge branch 'canary' into canary

6b61480

This comment has been minimized.

Sign in to view

Merge branch 'canary' into canary

dd6fcb8

This comment has been minimized.

Sign in to view

ijjk approved these changes Jan 27, 2022

View reviewed changes

Merge branch 'canary' into canary

e3ff015

This comment has been minimized.

Sign in to view

Merge branch 'canary' into canary

3697168

kodiakhq bot merged commit 662fa63 into vercel:canary Jan 27, 2022

github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixes #33314 move is-plain-object for es5 compilation #33690

fix: fixes #33314 move is-plain-object for es5 compilation #33690

PizzaPete commented Jan 26, 2022 •

edited

This comment has been minimized.

This comment has been minimized.

PizzaPete commented Jan 26, 2022

This comment has been minimized.

ijjk left a comment

This comment has been minimized.

ijjk commented Jan 27, 2022

Diffs

Diffs

fix: fixes #33314 move is-plain-object for es5 compilation #33690

fix: fixes #33314 move is-plain-object for es5 compilation #33690

Conversation

PizzaPete commented Jan 26, 2022 • edited

Bug

This comment has been minimized.

This comment has been minimized.

PizzaPete commented Jan 26, 2022

This comment has been minimized.

ijjk left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Jan 27, 2022

Stats from current PR

Diffs

Diffs

PizzaPete commented Jan 26, 2022 •

edited