REMOVE: duplicate key in docs/testing.md #33681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffan0811
requested review from
huozhi,
ijjk,
leerob,
padmaia,
shuding,
styfle and
timneutkens
as code owners
ffan0811
changed the title
molebox
approved these changes
Jan 26, 2022
styfle
approved these changes
Jan 26, 2022
This was referenced Jan 27, 2022
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
There is a duplicate key, `testEnvironment` in one of the examples that are located in docs/testing.md. In my humble opinion, It is not good to have an error in examples. My suggestion is we have only one key and it is up to developers what options they have for the `testEnvironment`. ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a duplicate key,
testEnvironmentin one of the examples that are located in docs/testing.md.In my humble opinion, It is not good to have an error in examples.
My suggestion is we have only one key and it is up to developers what options they have for the
testEnvironment.Documentation / Examples
yarn lint