Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow certain variable names in development #33638

Merged
merged 4 commits into from Jan 27, 2022

Conversation

balazsorban44
Copy link
Member

Fixes #24570

A few variable names (listed #24570 (comment)) were causing problems when using next dev.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@clentfort
Copy link

Thanks for providing this fix @balazsorban44

@ijjk
Copy link
Member

ijjk commented Jan 27, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
buildDuration 12.3s 12.6s ⚠️ +288ms
buildDurationCached 3.2s 3.2s ⚠️ +14ms
nodeModulesSize 356 MB 356 MB ⚠️ +310 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
/ failed reqs 0 0
/ total time (seconds) 2.875 2.95 ⚠️ +0.08
/ avg req/sec 869.66 847.5 ⚠️ -22.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.381 1.378 0
/error-in-render avg req/sec 1810.7 1814.09 +3.39
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.4 kB 14.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
buildDuration 15.8s 16s ⚠️ +142ms
buildDurationCached 3.2s 3.2s ⚠️ +2ms
nodeModulesSize 356 MB 356 MB ⚠️ +310 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
/ failed reqs 0 0
/ total time (seconds) 2.928 2.965 ⚠️ +0.04
/ avg req/sec 853.73 843.22 ⚠️ -10.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.406 ⚠️ +0.03
/error-in-render avg req/sec 1819.39 1777.48 ⚠️ -41.91
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/allow-any-variable-names Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 590e2db

@kodiakhq kodiakhq bot merged commit 7e95e30 into canary Jan 27, 2022
@kodiakhq kodiakhq bot deleted the fix/allow-any-variable-names branch January 27, 2022 14:22
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
Fixes vercel#24570

A few variable names (listed vercel#24570 (comment)) were causing problems when using `next dev`.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev mode breaks when local variable _a or _b is already defined (ReactRefreshModule runtime)
4 participants