Implement web server as the request handler for edge SSR #33635

shuding · 2022-01-25T12:00:39Z

(#31506 for context)

This PR implements the minimum viable web server on top of the Next.js base server, and integrates it into our middleware (edge) SSR runtime to handle all the requests.

This also addresses problems like missing dynamic routes support in our current handler.

Note that this is the initial implementation with the assumption that the web server is running under minimal mode. Also later we can refactor the __server_context environment to properly passing the context via the constructor or methods.

This reverts commit 0b6f93e.

This reverts commit 7eda31b.

packages/next/build/entries.ts

packages/next/lib/chalk.ts

packages/next/build/entries.ts

huozhi

Nice work 👍

ijjk · 2022-01-26T06:15:40Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/504f	Change
buildDuration	18.1s	15.6s	-2.4s
buildDurationCached	4s	4s	⚠️ +59ms
nodeModulesSize	356 MB	356 MB	⚠️ +11.7 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/504f	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.134	3.768	-0.37
/ avg req/sec	604.75	663.43	+58.68
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.121	1.779	-0.34
/error-in-render avg req/sec	1178.66	1404.94	+226.28

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/504f	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71 kB	71 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/504f	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/504f	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.94 kB	4.94 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.4 kB	14.4 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/504f	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/504f	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	shuding/next.js shu/504f	Change
buildDuration	19.1s	20.4s	⚠️ +1.3s
buildDurationCached	4.1s	4.1s	⚠️ +21ms
nodeModulesSize	356 MB	356 MB	⚠️ +11.7 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	shuding/next.js shu/504f	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.65	3.637	-0.01
/ avg req/sec	684.88	687.41	+2.53
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.729	1.648	-0.08
/error-in-render avg req/sec	1445.94	1517.13	+71.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	shuding/next.js shu/504f	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.3 kB	27.3 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	shuding/next.js shu/504f	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	shuding/next.js shu/504f	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.97 kB	4.97 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.21 kB	2.21 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.3 kB	14.3 kB	✓

Client Build Manifests

	vercel/next.js canary	shuding/next.js shu/504f	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	shuding/next.js shu/504f	Change
index.html gzip	529 B	529 B	✓
link.html gzip	543 B	543 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 4df0630

leo · 2022-02-10T15:03:13Z

This change seems to have caused #34185.

(vercel#31506 for context) This PR implements the minimum viable web server on top of the Next.js base server, and integrates it into our middleware (edge) SSR runtime to handle all the requests. This also addresses problems like missing dynamic routes support in our current handler. Note that this is the initial implementation with the assumption that the web server is running under minimal mode. Also later we can refactor the `__server_context` environment to properly passing the context via the constructor or methods.

shuding added 18 commits January 21, 2022 15:36

abstract manifest getters

3a0b602

Merge branch 'canary' into shu/504f

f7870fa

remove unused imports

1ea2af3

create web server

ebc348a

merge canary

916544f

initial implementation of web-server

a224f25

try importing the web server

7b38b1b

load manifest before initializing super

e788b66

pass manifests

7eda31b

add routes and pages manifests

0b6f93e

Revert "add routes and pages manifests"

2e656b2

This reverts commit 0b6f93e.

Revert "pass manifests"

26c6914

This reverts commit 7eda31b.

fix chalk and pass config to the loader

e89bcfb

move manifest getter

14162d0

pipe the server res

5e574b6

clean up

8790427

test dynamic route

558333e

current page route

08538b3

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 25, 2022

This comment has been minimized.

Sign in to view

fix dynamic route tests

c0a75b8

This comment has been minimized.

Sign in to view

shuding added 2 commits January 25, 2022 18:03

fix test case

42b76d4

fix partial hydration

9701499

This comment has been minimized.

Sign in to view

shuding added 2 commits January 25, 2022 18:58

fix dev opts

9bc2728

fix dev flag

b5e7949

shuding added 2 commits January 25, 2022 20:51

clean up

f5b4401

fix type errors

ce6e1a2

huozhi reviewed Jan 25, 2022

View reviewed changes

packages/next/build/entries.ts Show resolved Hide resolved

huozhi reviewed Jan 25, 2022

View reviewed changes

packages/next/lib/chalk.ts Show resolved Hide resolved

This comment has been minimized.

Sign in to view

huozhi reviewed Jan 25, 2022

View reviewed changes

packages/next/build/entries.ts Show resolved Hide resolved

huozhi previously approved these changes Jan 25, 2022

View reviewed changes

kodiakhq bot and others added 2 commits January 25, 2022 21:43

Merge branch 'canary' into shu/504f

4445d87

fix stringify

c0b7c2e

shuding dismissed huozhi’s stale review via c0b7c2e January 25, 2022 21:49

shuding requested a review from huozhi January 25, 2022 21:57

shuding mentioned this pull request Jan 25, 2022

Ensure rewrites, i18n and middleware are working properly with the web server #33664

Open

This comment has been minimized.

Sign in to view

huozhi approved these changes Jan 25, 2022

View reviewed changes

Merge branch 'canary' into shu/504f

4df0630

kodiakhq bot merged commit 99d4d6c into vercel:canary Jan 26, 2022

shuding deleted the shu/504f branch January 26, 2022 07:25

leo mentioned this pull request Feb 10, 2022

12.0.9-canary.11 5x'd size of edge SSR bundle #34185

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement web server as the request handler for edge SSR #33635

Implement web server as the request handler for edge SSR #33635

shuding commented Jan 25, 2022 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

huozhi left a comment

This comment has been minimized.

ijjk commented Jan 26, 2022

leo commented Feb 10, 2022

Implement web server as the request handler for edge SSR #33635

Implement web server as the request handler for edge SSR #33635

Conversation

shuding commented Jan 25, 2022 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

huozhi left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ijjk commented Jan 26, 2022

Stats from current PR

leo commented Feb 10, 2022

shuding commented Jan 25, 2022 •

edited