Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc #33342

Merged
merged 1 commit into from Jan 17, 2022
Merged

Update swc #33342

merged 1 commit into from Jan 17, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 15, 2022

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 15, 2022
@ijjk
Copy link
Member

ijjk commented Jan 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up-3 Change
buildDuration 16.2s 16.3s ⚠️ +108ms
buildDurationCached 3.8s 3.5s -270ms
nodeModulesSize 355 MB 355 MB -15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-3 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.347 3.343 0
/ avg req/sec 746.97 747.89 +0.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.538 1.546 ⚠️ +0.01
/error-in-render avg req/sec 1625.49 1617.42 ⚠️ -8.07
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-3 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-3 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-3 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.7 kB 4.7 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-3 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-3 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-up-3 Change
buildDuration 17.8s 17.7s -92ms
buildDurationCached 3.7s 3.4s -271ms
nodeModulesSize 355 MB 355 MB -15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-3 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.323 3.308 -0.02
/ avg req/sec 752.28 755.73 +3.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.522 1.576 ⚠️ +0.05
/error-in-render avg req/sec 1642.12 1586.3 ⚠️ -55.82
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-3 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-3 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-3 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-3 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-3 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: 6358318

@timneutkens timneutkens merged commit aaa77dd into vercel:canary Jan 17, 2022
@timneutkens timneutkens deleted the swc-up-3 branch January 17, 2022 14:09
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@kdy1 @natew
Update swc (vercel#33342)
ff6bb9a
@vercel vercel locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using spread props in a next/head child causes void elements to be decorated with a children prop
4 participants
@kdy1 @ijjk @timneutkens @balazsorban44