Update yarn PnP tests and disable swc file reading for PnP #33236

ijjk · 2022-01-12T22:08:57Z

This adds regression tests for the fix for yarn PnP in #32867 and also ensures we disable swc file reading by default when in PnP mode so that users don't have to disable it every time.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

x-ref: #32867
x-ref: #31690
x-ref: #31812
Fixes: #32115 (comment)

This reverts commit 3a6e924.

test/e2e/yarn-pnp/test/utils.ts

test/lib/next-modes/next-dev.ts

ijjk · 2022-01-14T14:26:13Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
buildDuration	16.8s	16.7s	-102ms
buildDurationCached	3.7s	3.7s	-70ms
nodeModulesSize	355 MB	355 MB	⚠️ +173 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.366	3.421	⚠️ +0.05
/ avg req/sec	742.8	730.71	⚠️ -12.09
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.512	1.538	⚠️ +0.03
/error-in-render avg req/sec	1653.3	1625.43	⚠️ -27.87

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71 kB	71 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.7 kB	4.7 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
buildDuration	18.5s	18.4s	-46ms
buildDurationCached	3.7s	3.7s	⚠️ +10ms
nodeModulesSize	355 MB	355 MB	⚠️ +173 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.346	3.378	⚠️ +0.03
/ avg req/sec	747.1	740.11	⚠️ -6.99
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.49	1.517	⚠️ +0.03
/error-in-render avg req/sec	1678.35	1648.42	⚠️ -29.93

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.3 kB	27.3 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js fix/yarn-pnp-tests	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 0e8a91e

arcanis · 2022-01-14T15:52:21Z

packages/next/build/webpack/loaders/next-swc-loader.js

+      !process.versions.pnp &&
      loaderOptions.fileReading &&
      !EXCLUDED_PATHS.test(this.resourcePath) &&


It's weird - why isn't EXCLUDED_PATHS enough? 🤔 Is this.resourcePath the right parameter? Looking at the report in #31812 (comment) it shows that the reported path should match:

C:\test-nextjs\.yarn\__virtual__\next-virtual-c649e2e81d\0\cache\next-npm-12.0.8-aa55acca00-947f0295aa.zip\node_modules\next\dist\client\dev\amp-dev.js

~~The regex doesn't seem to match the above case:~~

It seems to safer to avoid this slight optimization for the PnP case, although if it is a noticeable difference in performance we could update the regex.

Note that you need to escape the backslashes in the literal for the regex to match:

console.log(EXCLUDED_PATHS.test('C:\\test-nextjs\\.yarn\\__virtual__\\next-virtual-c649e2e81d\\0\\cache\\next-npm-12.0.8-aa55acca00-947f0295aa.zip\\node_modules\\next\\dist\\client\\dev\\amp-dev.js'))

Ah right, hmm yeah I'm not able to find any mis-matches shared in the errors from the threads 🤔

Update yarn PnP tests and disable swc file reading for PnP

644a278

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 12, 2022

ijjk mentioned this pull request Jan 12, 2022

Fix broken yarn pnp #32867

Merged

10 tasks

ijjk added 5 commits January 12, 2022 16:11

update job

1106a5a

Update test

12d6bf4

add env variable

669d6d7

update destory

0695815

test one

c8d2fcc

rtritto mentioned this pull request Jan 13, 2022

Error: Failed to read source code from amp-dev.js #31812

Closed

balazsorban44 linked an issue Jan 13, 2022 that may be closed by this pull request

Error: Failed to read source code from amp-dev.js #31812

Closed

ijjk added 12 commits January 12, 2022 19:27

bump timeout

646f856

update pnp install command

991f6b0

only run pnp test

0fd5b6e

add more logs

ee22285

handle exit signal

719d4dc

dont inherit stdio for install

369d023

update server start

1cfa2bd

re-add test type

218e396

add build log

e9c5677

additional logging

9500633

update build command

8bb963a

remove separate timeout

9aaa18c

rtritto mentioned this pull request Jan 13, 2022

yarn create next-app and run not work as expected #32721

Closed

ijjk added 6 commits January 13, 2022 09:19

update install command

c0a3d48

install separate for better time info

0fd6bd0

add cache pre-warming

a100a1d

update yarn config

f9de7fd

enable other pnp tests

c38011f

Separate out tests

0766c3b

ijjk added 6 commits January 13, 2022 10:36

fix-lint

cc86f89

update path

fed6184

update test concurrency for isolated tests

3a6e924

update retries

4925c87

Revert "update test concurrency for isolated tests"

0536c9c

This reverts commit 3a6e924.

re-enable production tests

d794a87

balazsorban44 mentioned this pull request Jan 13, 2022

ReferenceError: regeneratorRuntime is not defined in next v10 #23720

Closed

Merge branch 'canary' into fix/yarn-pnp-tests

27c84ba

This comment has been minimized.

Sign in to view

ijjk marked this pull request as ready for review January 13, 2022 20:48

ijjk requested review from huozhi, padmaia, shuding, styfle and timneutkens as code owners January 13, 2022 20:48

styfle reviewed Jan 13, 2022

View reviewed changes

test/e2e/yarn-pnp/test/utils.ts Show resolved Hide resolved

styfle reviewed Jan 14, 2022

View reviewed changes

test/lib/next-modes/next-dev.ts Outdated Show resolved Hide resolved

styfle previously approved these changes Jan 14, 2022

View reviewed changes

ijjk added 2 commits January 14, 2022 07:57

Merge branch 'canary' into fix/yarn-pnp-tests

f6d719f

apply suggestions

0e8a91e

ijjk dismissed styfle’s stale review via 0e8a91e January 14, 2022 14:01

styfle approved these changes Jan 14, 2022

View reviewed changes

ijjk merged commit 613e4c9 into vercel:canary Jan 14, 2022

ijjk deleted the fix/yarn-pnp-tests branch January 14, 2022 15:43

arcanis reviewed Jan 14, 2022

View reviewed changes

This was referenced Jan 18, 2022

next dev and next build broken on Yarn PnP in the latest release #32115

Closed

12.0.2 regression: can no longer import uuid package (a package with exports) with yarn pnp #31226

Closed

vercel locked as resolved and limited conversation to collaborators Feb 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update yarn PnP tests and disable swc file reading for PnP #33236

Update yarn PnP tests and disable swc file reading for PnP #33236

ijjk commented Jan 12, 2022 •

edited

This comment has been minimized.

ijjk commented Jan 14, 2022

arcanis Jan 14, 2022

ijjk Jan 14, 2022 •

edited

arcanis Jan 14, 2022 •

edited

ijjk Jan 14, 2022

Update yarn PnP tests and disable swc file reading for PnP #33236

Update yarn PnP tests and disable swc file reading for PnP #33236

Conversation

ijjk commented Jan 12, 2022 • edited

Bug

This comment has been minimized.

ijjk commented Jan 14, 2022

Stats from current PR

arcanis Jan 14, 2022

Choose a reason for hiding this comment

ijjk Jan 14, 2022 • edited

Choose a reason for hiding this comment

arcanis Jan 14, 2022 • edited

Choose a reason for hiding this comment

ijjk Jan 14, 2022

Choose a reason for hiding this comment

ijjk commented Jan 12, 2022 •

edited

ijjk Jan 14, 2022 •

edited

arcanis Jan 14, 2022 •

edited