Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update webpack #33207

Merged
merged 2 commits into from Jan 12, 2022
Merged

update webpack #33207

merged 2 commits into from Jan 12, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 12, 2022 •
edited

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 12, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@sokra sokra marked this pull request as ready for review January 12, 2022 16:15
@ijjk
Copy link
Member

ijjk commented Jan 12, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 18.7s 19.1s ⚠️ +461ms
buildDurationCached 4.1s 4.1s ⚠️ +1ms
nodeModulesSize 355 MB 355 MB ⚠️ +99.9 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.999 3.952 -0.05
/ avg req/sec 625.12 632.57 +7.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.101 2.081 -0.02
/error-in-render avg req/sec 1190.03 1201.19 +11.16
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/update Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.44 kB -1 B
Overall change 71 kB 71 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.74 kB 4.74 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 532 B 530 B -2 B
link.html gzip 546 B 545 B -1 B
withRouter.html gzip 527 B 526 B -1 B
Overall change 1.6 kB 1.6 kB -4 B

Diffs

Diff for webpack-HASH.js 
@@ -416,7 +416,7 @@
           /******/ installedChunks[chunkId][0]();
           /******/
         }
-        /******/ installedChunks[chunkIds[i]] = 0;
+        /******/ installedChunks[chunkId] = 0;
         /******/
       }
       /******/ return __webpack_require__.O(result);
Diff for index.html 
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-5cd94c89d3acac5f.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-8244d589778df4b1.js"
+      src="/_next/static/chunks/webpack-019d6affc74a3adc.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-5cd94c89d3acac5f.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-8244d589778df4b1.js"
+      src="/_next/static/chunks/webpack-019d6affc74a3adc.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-5cd94c89d3acac5f.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-8244d589778df4b1.js"
+      src="/_next/static/chunks/webpack-019d6affc74a3adc.js"
       defer=""
     ></script>
     <script
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
buildDuration 20.6s 21s ⚠️ +447ms
buildDurationCached 4.1s 4.1s ⚠️ +25ms
nodeModulesSize 355 MB 355 MB ⚠️ +99.9 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/update Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.986 4.079 ⚠️ +0.09
/ avg req/sec 627.23 612.86 ⚠️ -14.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.146 2.15 0
/error-in-render avg req/sec 1165.01 1162.87 ⚠️ -2.14
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/update Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB -3 B
Overall change 71.2 kB 71.2 kB -3 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/update Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/update Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.76 kB 4.76 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/update Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/update Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 544 B -1 B
withRouter.html gzip 526 B 527 B ⚠️ +1 B
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for webpack-HASH.js 
@@ -416,7 +416,7 @@
           /******/ installedChunks[chunkId][0]();
           /******/
         }
-        /******/ installedChunks[chunkIds[i]] = 0;
+        /******/ installedChunks[chunkId] = 0;
         /******/
       }
       /******/ return __webpack_require__.O(result);
Diff for index.html 
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-5cd94c89d3acac5f.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-8244d589778df4b1.js"
+      src="/_next/static/chunks/webpack-019d6affc74a3adc.js"
       defer=""
     ></script>
     <script
Diff for link.html 
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-5cd94c89d3acac5f.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-8244d589778df4b1.js"
+      src="/_next/static/chunks/webpack-019d6affc74a3adc.js"
       defer=""
     ></script>
     <script
Diff for withRouter.html 
@@ -11,7 +11,7 @@
       src="/_next/static/chunks/polyfills-5cd94c89d3acac5f.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-8244d589778df4b1.js"
+      src="/_next/static/chunks/webpack-019d6affc74a3adc.js"
       defer=""
     ></script>
     <script
Commit: 584f283

@kodiakhq kodiakhq bot merged commit 3ee3ec3 into canary Jan 12, 2022
@kodiakhq kodiakhq bot deleted the webpack/update branch January 12, 2022 16:47
@balazsorban44 balazsorban44 mentioned this pull request Jan 17, 2022
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @huozhi