Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master branch to main #33153

Closed
mannybecerra opened this issue Jan 10, 2022 · 4 comments · May be fixed by Qdigital/next.js#257, elad165/next.js#1142, adamlaska/next.js#405, Qdigital/next.js#258 or elad165/next.js#1143

Comments

@mannybecerra
Copy link
Contributor

Describe the feature you'd like to request

Adopt naming conventions that are more meaningful and inclusive; more specifically, and as the PR title suggests, rename the current master branch from master to main.

  • This would require the canary to master rebase flow to obviously need some configuration change, hopefully this is little effort (in relative terms).

Describe the solution you'd like

Refer to above section and this sibling suggestion in the swr-site repo that was made and adopted over the weekend, vercel/swr-site#206.

Additional resources: https://github.com/github/renaming

Describe alternatives you've considered

The alternative is to leave the current master branch name as-is, however, that doesn't seem like a good alternative.

@balazsorban44
Copy link
Member

This was/is intended as said here #21039 (comment)

It was admittedly a long time ago, so I'll check with the team how is this going and if we are blocked still.

@timneutkens
Copy link
Member

Updated the branch name, we kept it as-is for a while as underlying automation systems and the website had to be updated to leverage tags instead of the branch itself. The branch hasn't been used since the 11.0.1 release 7+ months ago as everything is now based on the canary branch.

mannybecerra added a commit to mannybecerra/next.js that referenced this issue Jan 11, 2022
…ter` branch to renamed default branch of `main`
@mannybecerra
Copy link
Contributor Author

Updated the branch name, we kept it as-is for a while as underlying automation systems and the website had to be updated to leverage tags instead of the branch itself. The branch hasn't been used since the 11.0.1 release 7+ months ago as everything is now based on the canary branch.

Sweet! Not sure if this supplementary PR was needed but out of due dilgence, I created it, #33198.

Thanks @timneutkens

mannybecerra added a commit to mannybecerra/next.js that referenced this issue Jan 11, 2022
…ter` branch to renamed default branch of `main`
balazsorban44 pushed a commit that referenced this issue Jan 12, 2022
…33198)

* copy cleanup in env. variables docs

* copy cleanup in fast refresh docs

* Supplements #33153 - updating existing cross-references to `master` branch to renamed default branch of `main`

* Supplements #33153 - updating existing cross-references to `master` branch to renamed default branch of `main`

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
teleaziz added a commit to teleaziz/next.js that referenced this issue Jan 12, 2022
…o-example

* 'canary' of github.com:vercel/next.js:
  Added links to data fetching api refs, fixed title (vercel#33221)
  Removed backticks on data fetching api titles (vercel#33216)
  middlewares: limit `process.env` to inferred usage (vercel#33186)
  Fixed broken link (vercel#33209)
  v12.0.8
  v12.0.8-canary.22
  Refactor data fetching API docs (vercel#30615)
  Docs: correct ignorance pattern for .env.local (vercel#32647)
  Fixes vercel#33153: Updating cross-references from master to main + canary (vercel#33198)
  v12.0.8-canary.21
  Add util for normalizing errors (vercel#33159)
  Fix broken yarn pnp (vercel#32867)
kodiakhq bot pushed a commit that referenced this issue Jan 14, 2022
contributing.md file still refers `master` branch name since the branch renamed as `main` recently. This PR contains a fix for that.

**related:**
#33153
#33198

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`


Co-authored-by: Tim Neutkens <6324199+timneutkens@users.noreply.github.com>
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Feb 11, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
…anary (vercel#33198)

* copy cleanup in env. variables docs

* copy cleanup in fast refresh docs

* Supplements vercel#33153 - updating existing cross-references to `master` branch to renamed default branch of `main`

* Supplements vercel#33153 - updating existing cross-references to `master` branch to renamed default branch of `main`

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.