Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated PostCSS #33135

Closed
romainmenke opened this issue Jan 10, 2022 · 4 comments · Fixed by #33142
Closed

Outdated PostCSS #33135

romainmenke opened this issue Jan 10, 2022 · 4 comments · Fixed by #33142
Labels
bug Issue was opened via the bug report template.

Comments

@romainmenke
Copy link

romainmenke commented Jan 10, 2022

Describe the Bug

PostCSS is listed as a direct dependency with a pinned version.
This makes it impossible for users to use plugins that require a higher version.

Context : csstools/postcss-plugins#147

Expected

PostCSS should be peer dependency with relaxed constraints

having a slightly more flexible issue template would also be nice :D

@romainmenke romainmenke added the bug Issue was opened via the bug report template. label Jan 10, 2022
@romainmenke
Copy link
Author

romainmenke commented Jan 10, 2022

@balazsorban44 #33142

This does fix the immediate bug people might be having, but doesn't fix the underlying issue.

Those versions should not be pinned and postcss should be a peer depedency.
Only a matter of time before this happen again.

@romainmenke
Copy link
Author

@kodiakhq kodiakhq bot closed this as completed in #33142 Jan 13, 2022
kodiakhq bot pushed a commit that referenced this issue Jan 13, 2022
Fixes #33135

I also tried reducing the number of variants.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@romainmenke
Copy link
Author

@timneutkens @ijjk @balazsorban44 please keep in mind that you will need to do this regularly and that you can also expect bug reports with the inverse.

It is also possible for plugins to only work with older versions of PostCSS.
This should be rarer with semver, but it still happens.

Maybe better to consider a more sustainable solution that gives some freedom to users?

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Feb 13, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
Fixes vercel#33135

I also tried reducing the number of variants.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants