New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated PostCSS #33135
Comments
This does fix the immediate bug people might be having, but doesn't fix the underlying issue. Those versions should not be pinned and postcss should be a peer depedency. |
Tailwind is a good example of how to handle this : https://github.com/tailwindlabs/tailwindcss/blob/62569092e7ba79fc45f77451c179b3f6cc0f80f8/package.json#L62-L65 |
Fixes #33135 I also tried reducing the number of variants. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
@timneutkens @ijjk @balazsorban44 please keep in mind that you will need to do this regularly and that you can also expect bug reports with the inverse. It is also possible for plugins to only work with older versions of PostCSS. Maybe better to consider a more sustainable solution that gives some freedom to users? |
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Fixes vercel#33135 I also tried reducing the number of variants. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`
Describe the Bug
PostCSS is listed as a direct dependency with a pinned version.
This makes it impossible for users to use plugins that require a higher version.
Context : csstools/postcss-plugins#147
Expected
PostCSS should be peer dependency with relaxed constraints
having a slightly more flexible issue template would also be nice :D
The text was updated successfully, but these errors were encountered: