Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadableStream.pipeTo() being unimplemented in the web runtime #32602

Merged
merged 2 commits into from Dec 17, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Dec 17, 2021

Currently we are using a TransformStream to process the forwarded stream for the inlined data, but unfortunately the pipeTo method is not implemented in the web runtime. This PR changes it to a naive way of doing so.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Dec 17, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8589 Change
buildDuration 18s 18.3s ⚠️ +313ms
buildDurationCached 3.4s 3.4s -1ms
nodeModulesSize 348 MB 348 MB ⚠️ +572 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/8589 Change
/ failed reqs 0 0
/ total time (seconds) 2.93 2.984 ⚠️ +0.05
/ avg req/sec 853.12 837.74 ⚠️ -15.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.336 1.406 ⚠️ +0.07
/error-in-render avg req/sec 1871.3 1777.82 ⚠️ -93.48
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/8589 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8589 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/8589 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8589 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8589 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/8589 Change
buildDuration 19.7s 19.7s -36ms
buildDurationCached 3.4s 3.4s -57ms
nodeModulesSize 348 MB 348 MB ⚠️ +572 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/8589 Change
/ failed reqs 0 0
/ total time (seconds) 2.87 2.938 ⚠️ +0.07
/ avg req/sec 871.04 850.97 ⚠️ -20.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.33 1.303 -0.03
/error-in-render avg req/sec 1880.03 1918.68 +38.65
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/8589 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.3 kB 74.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/8589 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/8589 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/8589 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/8589 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 0137e13

@kodiakhq kodiakhq bot merged commit 346670c into vercel:canary Dec 17, 2021
@shuding shuding deleted the shu/8589 branch December 17, 2021 12:42
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants