Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AMP optimizer is only excluded from trace when not used #32577

Merged
merged 2 commits into from Dec 17, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 16, 2021

This ensures we only ignore the AMP optimizer module while tracing when no AMP SSR pages are being used similar to our previous ignore handling.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 16, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review December 16, 2021 17:07
@ijjk
Copy link
Member Author

ijjk commented Dec 17, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
buildDuration 17.4s 17.5s ⚠️ +78ms
buildDurationCached 3.3s 3.3s ⚠️ +36ms
nodeModulesSize 348 MB 348 MB ⚠️ +357 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
/ failed reqs 0 0
/ total time (seconds) 2.724 2.721 0
/ avg req/sec 917.88 918.87 +0.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.185 1.144 -0.04
/error-in-render avg req/sec 2110.13 2185.13 +75
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
buildDuration 18.7s 18.9s ⚠️ +175ms
buildDurationCached 3.3s 3.3s ⚠️ +32ms
nodeModulesSize 348 MB 348 MB ⚠️ +357 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
/ failed reqs 0 0
/ total time (seconds) 2.753 2.735 -0.02
/ avg req/sec 908.05 913.91 +5.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.178 1.147 -0.03
/error-in-render avg req/sec 2121.99 2179.07 +57.08
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.3 kB 74.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/amp-output-trace Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: fa6f78e

@ijjk ijjk merged commit f61e356 into vercel:canary Dec 17, 2021
@ijjk ijjk deleted the fix/amp-output-trace branch December 17, 2021 19:57
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants