Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc #32566

Merged
merged 2 commits into from Dec 16, 2021
Merged

Update swc #32566

merged 2 commits into from Dec 16, 2021
+56 −54

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 16, 2021 •
edited by timneutkens

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 16, 2021
@ijjk
Copy link
Member

ijjk commented Dec 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-parser-fix Change
buildDuration 20.5s 20.6s ⚠️ +77ms
buildDurationCached 3.8s 3.8s -23ms
nodeModulesSize 348 MB 348 MB -14 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-parser-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.353 3.318 -0.04
/ avg req/sec 745.6 753.44 +7.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.529 1.5 -0.03
/error-in-render avg req/sec 1634.56 1667.16 +32.6
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-parser-fix Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-parser-fix Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-parser-fix Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-parser-fix Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-parser-fix Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-parser-fix Change
buildDuration 22.2s 22s -199ms
buildDurationCached 3.8s 3.8s ⚠️ +75ms
nodeModulesSize 348 MB 348 MB -14 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-parser-fix Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.296 3.32 ⚠️ +0.02
/ avg req/sec 758.41 752.93 ⚠️ -5.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.488 1.48 -0.01
/error-in-render avg req/sec 1679.82 1689.24 +9.42
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-parser-fix Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-parser-fix Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-parser-fix Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-parser-fix Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-parser-fix Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 7254f65

@balazsorban44
Copy link
Member

I think it should fix this #32470 as well

@kodiakhq kodiakhq bot merged commit 99f9be5 into vercel:canary Dec 16, 2021
@leroydev leroydev mentioned this pull request Dec 16, 2021
Closed
@kdy1 kdy1 deleted the swc-parser-fix branch January 20, 2022 07:33
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@kdy1 @natew
Update swc (vercel#32566)
600ef50 
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


This applies

 - swc-project/swc#3051

Fixes vercel#32553

 - swc-project/swc#3023

Fixes vercel#32470
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
4 participants
@kdy1 @ijjk @balazsorban44 @timneutkens