Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure image-optimizer is traced for standalone mode #32522

Merged
merged 2 commits into from Dec 15, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 15, 2021

This ensures we trace the image-optimizer for the standalone output mode as previously this was always ignored under the assumption image optimizing would be handled at the CDN level in standalone mode.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Fixes: #32513

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 15, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review December 15, 2021 04:00
@ijjk
Copy link
Member Author

ijjk commented Dec 15, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
buildDuration 18s 18s ⚠️ +12ms
buildDurationCached 3.4s 3.4s -16ms
nodeModulesSize 350 MB 350 MB ⚠️ +1.47 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
/ failed reqs 0 0
/ total time (seconds) 2.921 2.9 -0.02
/ avg req/sec 855.89 862.17 +6.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.36 1.353 -0.01
/error-in-render avg req/sec 1837.6 1847.22 +9.62
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
buildDuration 19.6s 19.5s -116ms
buildDurationCached 3.4s 3.5s ⚠️ +94ms
nodeModulesSize 350 MB 350 MB ⚠️ +1.47 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
/ failed reqs 0 0
/ total time (seconds) 2.932 2.962 ⚠️ +0.03
/ avg req/sec 852.72 844.06 ⚠️ -8.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.33 1.342 ⚠️ +0.01
/error-in-render avg req/sec 1879.44 1862.29 ⚠️ -17.15
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.3 kB 74.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/standalone-image-optimizer Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: cf1c257

@kodiakhq kodiakhq bot merged commit 5d606eb into vercel:canary Dec 15, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using <Image /> component with-docker results in missing image-optimizer
2 participants