Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-swc/styled-jsx): Fix interpolation in media query #32490

Merged
merged 7 commits into from Dec 16, 2021
Merged

fix(next-swc/styled-jsx): Fix interpolation in media query #32490

merged 7 commits into from Dec 16, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 14, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Fixes #31562

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 14, 2021
kdy1
kdy1 commented Dec 14, 2021
View reviewed changes
packages/next-swc/crates/core/tests/fixture.rs
@@ -112,13 +99,20 @@ fn styled_jsx_span_should_not_affect_hash(input: PathBuf) {
let _mark = Mark::fresh(Mark::root());
}

chain!(as_folder(DropSpan), resolver(), styled_jsx())
chain!(resolver(), styled_jsx(t.cm.clone()))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed DropSpan because styled-jsx depends on span.

@ijjk
Copy link
Member

ijjk commented Dec 14, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
buildDuration 18.1s 17.9s -213ms
buildDurationCached 3.4s 3.3s -75ms
nodeModulesSize 351 MB 351 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.806 2.905 ⚠️ +0.1
/ avg req/sec 890.88 860.52 ⚠️ -30.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.35 1.315 -0.04
/error-in-render avg req/sec 1852.16 1900.51 +48.35
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
index.html gzip 532 B 532 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
buildDuration 19.3s 19.7s ⚠️ +430ms
buildDurationCached 3.2s 3.5s ⚠️ +270ms
nodeModulesSize 351 MB 351 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.889 2.911 ⚠️ +0.02
/ avg req/sec 865.22 858.71 ⚠️ -6.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.403 1.338 -0.06
/error-in-render avg req/sec 1781.79 1869.02 +87.23
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.2 kB 74.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js styled-jsx-31562 Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: d7c2f56

@timneutkens timneutkens merged commit 47cd07b into vercel:canary Dec 16, 2021
@timneutkens timneutkens deleted the styled-jsx-31562 branch December 16, 2021 11:23
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@media query interpolation broken in 12.0.4
3 participants
@kdy1 @ijjk @timneutkens