Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused classnames dependency from react-dev-overlay #32487

Merged
merged 3 commits into from Dec 15, 2021

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Dec 14, 2021

It seems that the classnames dependency is not referenced in the react-dev-overlay code.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was indeed removed 👍 Thanks!

@ijjk
Copy link
Member

ijjk commented Dec 15, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
buildDuration 16.5s 16.6s ⚠️ +148ms
buildDurationCached 3.1s 3.1s -88ms
nodeModulesSize 350 MB 350 MB -16.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
/ failed reqs 0 0
/ total time (seconds) 2.731 2.725 -0.01
/ avg req/sec 915.55 917.42 +1.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.223 1.217 -0.01
/error-in-render avg req/sec 2043.9 2054.86 +10.96
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 30.2 kB 30.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
buildDuration 17.2s 17.9s ⚠️ +613ms
buildDurationCached 3.1s 3.3s ⚠️ +200ms
nodeModulesSize 350 MB 350 MB -16.5 kB
Page Load Tests Overall increase ✓
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
/ failed reqs 0 0
/ total time (seconds) 2.688 2.646 -0.04
/ avg req/sec 930.2 944.92 +14.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.237 1.226 -0.01
/error-in-render avg req/sec 2021.55 2039.71 +18.16
Client Bundles (main, webpack, commons)
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 30.3 kB 30.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 74.3 kB 74.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary jorrit/next.js removeclassnamesdep Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: ce8e477

@kodiakhq kodiakhq bot merged commit f441a58 into vercel:canary Dec 15, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants