fixes to allow lazy compilation for import() #32441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sokra
force-pushed
the
feature/lazy-compilation
branch
from
95dbcac
to
d6eec90
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sokra
force-pushed
the
feature/lazy-compilation
branch
2 times, most recently
from
ae04c3c
to
e1245f3
Compare
Failing test suitesCommit: e1245f3 test/integration/app-document-add-hmr/test/index.test.js
Expand output● _app/_document add HMR › should HMR when _document is added |
This comment has been minimized.
This comment has been minimized.
sokra
force-pushed
the
feature/lazy-compilation
branch
from
e1245f3
to
83c69a9
Compare
Stats from current PRDefault Build (Decrease detected ✓)General Overall decrease ✓
Page Load Tests Overall decrease
|
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.93 | 2.885 | -0.05 |
| / avg req/sec | 853.35 | 866.45 | +13.1 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.319 | 1.346 | |
| /error-in-render avg req/sec | 1896 | 1857.51 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 28.9 kB | 28.9 kB | ✓ |
| webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
| Overall change | 72.8 kB | 72.8 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 326 B | 326 B | ✓ |
| dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 919 B | 919 B | ✓ |
| image-HASH.js gzip | 4.73 kB | 4.73 kB | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
| routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
| script-HASH.js gzip | 383 B | 383 B | ✓ |
| withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.1 kB | 14.1 kB |
Client Build Manifests
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| index.html gzip | 531 B | 531 B | ✓ |
| link.html gzip | 545 B | 545 B | ✓ |
| withRouter.html gzip | 526 B | 526 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Fcss-97182c5b8324021a.js"
],
"/dynamic": [
- "static\u002Fchunks\u002Fpages\u002Fdynamic-04217a0b90b030bc.js"
+ "static\u002Fchunks\u002Fpages\u002Fdynamic-6b716f7c69fc6182.js"
],
"/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
"/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-538d621a0e670391.js"],Diff for dynamic-HASH.js
@@ -374,44 +374,41 @@
if (false) {
}
// Client only
- if (
- !initialized &&
- "object" !== "undefined" &&
- typeof opts.webpack === "function" &&
- "function" === "function" &&
- !opts.suspense
- ) {
- var moduleIds = opts.webpack();
- READY_INITIALIZERS.push(function(ids) {
- var _iteratorNormalCompletion = true,
- _didIteratorError = false,
- _iteratorError = undefined;
- try {
- for (
- var _iterator = moduleIds[Symbol.iterator](), _step;
- !(_iteratorNormalCompletion = (_step = _iterator.next()).done);
- _iteratorNormalCompletion = true
- ) {
- var moduleId = _step.value;
- if (ids.indexOf(moduleId) !== -1) {
- return init();
- }
- }
- } catch (err) {
- _didIteratorError = true;
- _iteratorError = err;
- } finally {
+ if (!initialized && "object" !== "undefined" && !opts.suspense) {
+ var moduleIds = opts.webpack ? opts.webpack() : opts.modules;
+ if (moduleIds) {
+ READY_INITIALIZERS.push(function(ids) {
+ var _iteratorNormalCompletion = true,
+ _didIteratorError = false,
+ _iteratorError = undefined;
try {
- if (!_iteratorNormalCompletion && _iterator.return != null) {
- _iterator.return();
+ for (
+ var _iterator = moduleIds[Symbol.iterator](), _step;
+ !(_iteratorNormalCompletion = (_step = _iterator.next())
+ .done);
+ _iteratorNormalCompletion = true
+ ) {
+ var moduleId = _step.value;
+ if (ids.indexOf(moduleId) !== -1) {
+ return init();
+ }
}
+ } catch (err) {
+ _didIteratorError = true;
+ _iteratorError = err;
} finally {
- if (_didIteratorError) {
- throw _iteratorError;
+ try {
+ if (!_iteratorNormalCompletion && _iterator.return != null) {
+ _iterator.return();
+ }
+ } finally {
+ if (_didIteratorError) {
+ throw _iteratorError;
+ }
}
}
- }
- });
+ });
+ }
}
var LoadableComponent = opts.suspense ? LazyImpl : LoadableImpl;
LoadableComponent.preload = function() {Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| buildDuration | 19.3s | 19.6s | |
| buildDurationCached | 3.4s | 3.3s | -81ms |
| nodeModulesSize | 350 MB | 350 MB | -388 B |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.998 | 2.983 | -0.02 |
| / avg req/sec | 833.94 | 837.95 | +4.01 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.348 | 1.375 | |
| /error-in-render avg req/sec | 1854.02 | 1818.5 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
| main-HASH.js gzip | 29.1 kB | 29.1 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 73 kB | 73 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 305 B | 305 B | ✓ |
| css-HASH.js gzip | 321 B | 321 B | ✓ |
| dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | |
| head-HASH.js gzip | 342 B | 342 B | ✓ |
| hooks-HASH.js gzip | 906 B | 906 B | ✓ |
| image-HASH.js gzip | 4.75 kB | 4.75 kB | ✓ |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
| routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
| script-HASH.js gzip | 375 B | 375 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.1 kB | 14.1 kB |
Client Build Manifests
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js feature/lazy-compilation | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 546 B | 546 B | ✓ |
| withRouter.html gzip | 527 B | 527 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Fcss-97182c5b8324021a.js"
],
"/dynamic": [
- "static\u002Fchunks\u002Fpages\u002Fdynamic-04217a0b90b030bc.js"
+ "static\u002Fchunks\u002Fpages\u002Fdynamic-6b716f7c69fc6182.js"
],
"/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
"/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-538d621a0e670391.js"],Diff for dynamic-HASH.js
@@ -374,44 +374,41 @@
if (false) {
}
// Client only
- if (
- !initialized &&
- "object" !== "undefined" &&
- typeof opts.webpack === "function" &&
- "function" === "function" &&
- !opts.suspense
- ) {
- var moduleIds = opts.webpack();
- READY_INITIALIZERS.push(function(ids) {
- var _iteratorNormalCompletion = true,
- _didIteratorError = false,
- _iteratorError = undefined;
- try {
- for (
- var _iterator = moduleIds[Symbol.iterator](), _step;
- !(_iteratorNormalCompletion = (_step = _iterator.next()).done);
- _iteratorNormalCompletion = true
- ) {
- var moduleId = _step.value;
- if (ids.indexOf(moduleId) !== -1) {
- return init();
- }
- }
- } catch (err) {
- _didIteratorError = true;
- _iteratorError = err;
- } finally {
+ if (!initialized && "object" !== "undefined" && !opts.suspense) {
+ var moduleIds = opts.webpack ? opts.webpack() : opts.modules;
+ if (moduleIds) {
+ READY_INITIALIZERS.push(function(ids) {
+ var _iteratorNormalCompletion = true,
+ _didIteratorError = false,
+ _iteratorError = undefined;
try {
- if (!_iteratorNormalCompletion && _iterator.return != null) {
- _iterator.return();
+ for (
+ var _iterator = moduleIds[Symbol.iterator](), _step;
+ !(_iteratorNormalCompletion = (_step = _iterator.next())
+ .done);
+ _iteratorNormalCompletion = true
+ ) {
+ var moduleId = _step.value;
+ if (ids.indexOf(moduleId) !== -1) {
+ return init();
+ }
}
+ } catch (err) {
+ _didIteratorError = true;
+ _iteratorError = err;
} finally {
- if (_didIteratorError) {
- throw _iteratorError;
+ try {
+ if (!_iteratorNormalCompletion && _iterator.return != null) {
+ _iterator.return();
+ }
+ } finally {
+ if (_didIteratorError) {
+ throw _iteratorError;
+ }
}
}
- }
- });
+ });
+ }
}
var LoadableComponent = opts.suspense ? LazyImpl : LoadableImpl;
LoadableComponent.preload = function() {
sokra
requested review from
huozhi,
ijjk,
padmaia,
shuding and
timneutkens
as code owners
timneutkens
approved these changes
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the webpack lazy compilation feature for lazy compiling
import()s on client side with next.js:lazy compilation for entries is not possible and not needed as next.js has it's own lazy compilation of entries.
lazy compilation on server-side is not (yet) possible since there is not HMR on server-side with next.js.
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
yarn lint