Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jsx transform of swc #32383

Merged
merged 4 commits into from Dec 13, 2021
Merged

Update jsx transform of swc #32383

merged 4 commits into from Dec 13, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 11, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

This PR applies

This fixes development mode of jsx.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 11, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Dec 13, 2021

Failing test suites

Commit: d5b1721

test/integration/app-document-add-hmr/test/index.test.js

  • _app/_document add HMR > should HMR when _document is added
Expand output

● _app/_document add HMR › should HMR when _document is added

TIMED OUT: success

<head><style data-next-hide-fouc="true">body{display:none}</style><noscript data-next-hide-fouc="true"><style>body{display:block}</style></noscript><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1639400637570"></script><script src="/_next/static/chunks/webpack.js?ts=1639400637570" defer=""></script><script src="/_next/static/chunks/main.js?ts=1639400637570" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1639400637570" defer=""></script><script src="/_next/static/chunks/pages/index.js?ts=1639400637570" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1639400637570" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1639400637570" defer=""></script><script src="/_next/static/development/_middlewareManifest.js?ts=1639400637570" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><div id="__next" data-reactroot=""><p>custom _app</p><p>index page</p></div><script src="/_next/static/chunks/react-refresh.js?ts=1639400637570"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script></body>

  479 |     if (!this.originalContent) {
  480 |       this.originalContent = content
> 481 |     }
      |      ^
  482 |     writeFileSync(this.path, content, 'utf8')
  483 |   }
  484 |

  at Object.check (lib/next-test-utils.js:481:15)
  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:83:13)

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Dec 13, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-react-dev Change
buildDuration 20.3s 20.2s -122ms
buildDurationCached 3.7s 3.7s ⚠️ +44ms
nodeModulesSize 350 MB 350 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-react-dev Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.366 3.435 ⚠️ +0.07
/ avg req/sec 742.82 727.83 ⚠️ -14.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.475 1.595 ⚠️ +0.12
/error-in-render avg req/sec 1694.84 1567.8 ⚠️ -127.04
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-react-dev Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.9 kB 28.9 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.8 kB 72.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-react-dev Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-react-dev Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-react-dev Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-react-dev Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary kdy1/next.js swc-react-dev Change
buildDuration 21.5s 21.7s ⚠️ +244ms
buildDurationCached 3.7s 3.8s ⚠️ +78ms
nodeModulesSize 350 MB 350 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-react-dev Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.252 3.351 ⚠️ +0.1
/ avg req/sec 768.73 746.12 ⚠️ -22.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.455 1.503 ⚠️ +0.05
/error-in-render avg req/sec 1717.89 1663.71 ⚠️ -54.18
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-react-dev Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 29.1 kB 29.1 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 73 kB 73 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-react-dev Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-react-dev Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.39 kB 2.39 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-react-dev Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-react-dev Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: ac1580e

@kodiakhq kodiakhq bot merged commit 4c84150 into vercel:canary Dec 13, 2021
cdierkens pushed a commit to cdierkens/next.js that referenced this pull request Dec 20, 2021
@kdy1 @cdierkens
Update jsx transform of swc (vercel#32383)
3cbbc57 
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


This PR applies

 - swc-project/swc#2741

This fixes `development` mode of jsx.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 deleted the swc-react-dev branch March 30, 2022 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ijjk @timneutkens