Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running server with Polyfilled fetch #32368

Merged
merged 7 commits into from Dec 13, 2021
Merged

Conversation

javivelasco
Copy link
Member

Note: This PR is applying again changes landed #31935 that were reverted from an investigation.

This PR fixes #30398

By default Next will polyfill some fetch APIs (Request, Response, Header and fetch) only if fetch is not found in the global scope in certain entry points. If we have a custom server which is adding a global fetch (and only fetch) at the very top then the rest of APIs will not be polyfilled.

This PR adds a test on the custom server where we can add a custom polyfill for fetch with an env variable. This reproduces the issue since next-server.js will be required without having a polyfill for Response which makes it fail on requiring NextResponse. Then we remove the code that checks for subrequests to happen within the sandbox so that we don't need to polyfill next-server anymore.

The we also introduce an improvement on how we handle relative requests. Since #31858 introduced a port and hostname options for the server, we can always pass absolute URLs to the Middleware so we can always use the original nextUrl to pass it to fetch. This brings a lot of simplification for NextURL since we don't have to consider relative URLs no more.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 13, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary javivelasco/next.js fix-30398 Change
buildDuration 22.1s 21.4s -717ms
buildDurationCached 4s 4s ⚠️ +62ms
nodeModulesSize 350 MB 350 MB ⚠️ +5.25 kB
Page Load Tests Overall increase ✓
vercel/next.js canary javivelasco/next.js fix-30398 Change
/ failed reqs 0 0
/ total time (seconds) 3.592 3.461 -0.13
/ avg req/sec 696 722.33 +26.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.67 1.534 -0.14
/error-in-render avg req/sec 1497.09 1629.75 +132.66
Client Bundles (main, webpack, commons)
vercel/next.js canary javivelasco/next.js fix-30398 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary javivelasco/next.js fix-30398 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary javivelasco/next.js fix-30398 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary javivelasco/next.js fix-30398 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary javivelasco/next.js fix-30398 Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary javivelasco/next.js fix-30398 Change
buildDuration 22.9s 23s ⚠️ +103ms
buildDurationCached 4.1s 4s -138ms
nodeModulesSize 350 MB 350 MB ⚠️ +5.25 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary javivelasco/next.js fix-30398 Change
/ failed reqs 0 0
/ total time (seconds) 3.489 3.46 -0.03
/ avg req/sec 716.62 722.55 +5.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.577 1.629 ⚠️ +0.05
/error-in-render avg req/sec 1585.77 1534.52 ⚠️ -51.25
Client Bundles (main, webpack, commons)
vercel/next.js canary javivelasco/next.js fix-30398 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary javivelasco/next.js fix-30398 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary javivelasco/next.js fix-30398 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary javivelasco/next.js fix-30398 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary javivelasco/next.js fix-30398 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 3a76a8a

@kodiakhq kodiakhq bot merged commit 59f7676 into vercel:canary Dec 13, 2021
cdierkens pushed a commit to cdierkens/next.js that referenced this pull request Dec 20, 2021
**Note**: This PR is applying again changes landed vercel#31935 that were reverted from an investigation.

This PR fixes vercel#30398

By default Next will polyfill some fetch APIs (Request, Response, Header and fetch) only if fetch is not found in the global scope in certain entry points. If we have a custom server which is adding a global fetch (and only fetch) at the very top then the rest of APIs will not be polyfilled.

This PR adds a test on the custom server where we can add a custom polyfill for fetch with an env variable. This reproduces the issue since next-server.js will be required without having a polyfill for Response which makes it fail on requiring NextResponse. Then we remove the code that checks for subrequests to happen within the **sandbox** so that we don't need to polyfill `next-server` anymore.

The we also introduce an improvement on how we handle relative requests. Since vercel#31858 introduced a `port` and `hostname` options for the server, we can always pass absolute URLs to the Middleware so we can always use the original `nextUrl` to pass it to fetch. This brings a lot of simplification for `NextURL` since we don't have to consider relative URLs no more.

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [x] Errors have helpful link attached, see `contributing.md`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@javivelasco javivelasco deleted the fix-30398 branch April 26, 2022 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting "ReferenceError: Response is not defined" while trying to upgrade an app from next 11 to next 12
2 participants