Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unstable_useRefreshRoot typing #32364

Merged
merged 2 commits into from Dec 10, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 10, 2021

align with re-exports in entry file

@ijjk

This comment has been minimized.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 10, 2021
@shuding
Copy link
Member

shuding commented Dec 10, 2021

It would be great to add a basic test for it.

@ijjk
Copy link
Member

ijjk commented Dec 10, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
buildDuration 18.8s 20s ⚠️ +1.2s
buildDurationCached 3.4s 3.4s ⚠️ +3ms
nodeModulesSize 351 MB 351 MB ⚠️ +14 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
/ failed reqs 0 0
/ total time (seconds) 3.027 3.032 0
/ avg req/sec 826.02 824.61 ⚠️ -1.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.478 1.447 -0.03
/error-in-render avg req/sec 1691.85 1727.77 +35.92
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.9 kB 28.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.8 kB 72.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
buildDuration 19.7s 19.8s ⚠️ +82ms
buildDurationCached 3.5s 4.8s ⚠️ +1.3s
nodeModulesSize 351 MB 351 MB ⚠️ +14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
/ failed reqs 0 0
/ total time (seconds) 3.031 3.067 ⚠️ +0.04
/ avg req/sec 824.75 815.25 ⚠️ -9.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.435 1.453 ⚠️ +0.02
/error-in-render avg req/sec 1742.1 1721.14 ⚠️ -20.96
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 29.1 kB 29.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-use-refresh-types Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 88ba1fb

@kodiakhq kodiakhq bot merged commit c21806e into vercel:canary Dec 10, 2021
@huozhi huozhi deleted the fix-use-refresh-types branch December 10, 2021 13:20
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants