fix(next-swc/styled-jsx): Fix `nth` #32358

kdy1 · 2021-12-10T06:58:12Z

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes by running yarn lint

ijjk · 2021-12-10T10:10:21Z

Failing test suites

Commit: 8599319

test/integration/app-document-add-hmr/test/index.test.js

_app/_document add HMR > should HMR when _document is added

Expand output

● _app/_document add HMR › should HMR when _document is added

expect(received).toContain(expected) // indexOf

Expected substring: "index page"
Received string:    "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1639131013464\"></script><script src=\"/_next/static/chunks/fallback/webpack.js?ts=1639131013464\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/main.js?ts=1639131013464\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_app.js?ts=1639131013464\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_error.js?ts=1639131013464\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body style=\"overflow: hidden;\"><div id=\"__next\" data-reactroot=\"\"></div><script src=\"/_next/static/chunks/fallback/react-refresh.js?ts=1639131013464\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"ModuleBuildError\",\"message\":\"Module build failed (from ../../../packages/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: Failed to read source code from /home/runner/work/next.js/next.js/test/integration/app-document-add-hmr/pages/_app.js\\n\\nCaused by:\\n    No such file or directory (os error 2)\",\"stack\":\"ModuleBuildError: Module build failed (from ../../../packages/next/dist/build/webpack/loaders/next-swc-loader.js):\\nError: Failed to read source code from /home/runner/work/next.js/next.js/test/integration/app-document-add-hmr/pages/_app.js\\n\\nCaused by:\\n    No such file or directory (os error 2)\\n    at processResult (/home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:54452:19)\\n    at /home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:54554:5\\n    at /home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:140425:11\\n    at /home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:140221:20\\n    at context.callback (/home/runner/work/next.js/next.js/packages/next/dist/compiled/webpack/bundle5.js:140150:13)\"},\"gip\":true,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer><nextjs-portal></nextjs-portal></body>"

  54 |       await fs.remove(appPage)
  55 |     }
> 56 |   })
     |     ^
  57 |
  58 |   it('should HMR when _document is added', async () => {
  59 |     let indexContent = await fs.readFile(indexPage)

  at Object.<anonymous> (integration/app-document-add-hmr/test/index.test.js:56:27)

ijjk · 2021-12-10T13:03:10Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	kdy1/next.js swc-nth	Change
buildDuration	19.5s	19.1s	-378ms
buildDurationCached	3.5s	3.5s	⚠️ +31ms
nodeModulesSize	351 MB	351 MB	-2 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kdy1/next.js swc-nth	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.305	3.523	⚠️ +0.22
/ avg req/sec	756.41	709.56	⚠️ -46.85
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.847	1.779	-0.07
/error-in-render avg req/sec	1353.79	1405.01	+51.22

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js swc-nth	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.9 kB	28.9 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.8 kB	72.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-nth	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-nth	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.39 kB	2.39 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-nth	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-nth	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	525 B	525 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	kdy1/next.js swc-nth	Change
buildDuration	20.6s	20.5s	-162ms
buildDurationCached	3.3s	3.6s	⚠️ +248ms
nodeModulesSize	351 MB	351 MB	-2 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	kdy1/next.js swc-nth	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.277	3.329	⚠️ +0.05
/ avg req/sec	762.79	750.88	⚠️ -11.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.708	1.666	-0.04
/error-in-render avg req/sec	1463.8	1500.65	+36.85

Client Bundles (main, webpack, commons)

	vercel/next.js canary	kdy1/next.js swc-nth	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	29.1 kB	29.1 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	73 kB	73 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	kdy1/next.js swc-nth	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	kdy1/next.js swc-nth	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.39 kB	2.39 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	906 B	906 B	✓
image-HASH.js gzip	4.75 kB	4.75 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	kdy1/next.js swc-nth	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	kdy1/next.js swc-nth	Change
index.html gzip	532 B	532 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: c946930

## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `yarn lint`

kdy1 added 3 commits December 10, 2021 15:36

Add a test

bc0b080

Handle nth

13ed0fc

Update test refs

863b44f

kdy1 requested review from huozhi, ijjk, shuding and timneutkens as code owners December 10, 2021 06:58

ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 10, 2021

This comment has been minimized.

Sign in to view

Merge branch 'canary' into swc-nth

8599319

This comment has been minimized.

Sign in to view

Merge branch 'canary' into swc-nth

f7be7ee

timneutkens approved these changes Dec 10, 2021

View reviewed changes

Merge branch 'canary' into swc-nth

c946930

kodiakhq bot merged commit 6015f3c into vercel:canary Dec 10, 2021

kdy1 deleted the swc-nth branch January 20, 2022 07:33

github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(next-swc/styled-jsx): Fix `nth` #32358

fix(next-swc/styled-jsx): Fix `nth` #32358

kdy1 commented Dec 10, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Dec 10, 2021

This comment has been minimized.

ijjk commented Dec 10, 2021

fix(next-swc/styled-jsx): Fix nth #32358

fix(next-swc/styled-jsx): Fix nth #32358

Conversation

kdy1 commented Dec 10, 2021

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

ijjk commented Dec 10, 2021

Failing test suites

This comment has been minimized.

ijjk commented Dec 10, 2021

Stats from current PR

fix(next-swc/styled-jsx): Fix `nth` #32358

fix(next-swc/styled-jsx): Fix `nth` #32358