New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unstable_useRefreshRoot #32342
Merged
Merged
Add unstable_useRefreshRoot #32342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: bec7d7f test/integration/react-streaming-and-server-components/test/index.test.js
Expand output● concurrentFeatures - dev › should support next/link
|
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
buildDuration | 20.2s | 20.1s | -121ms |
buildDurationCached | 3.8s | 3.8s | |
nodeModulesSize | 351 MB | 351 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.52 | 3.267 | -0.25 |
/ avg req/sec | 710.3 | 765.13 | +54.83 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.622 | 1.525 | -0.1 |
/error-in-render avg req/sec | 1541.24 | 1639.54 | +98.3 |
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 28.8 kB | 28.9 kB | |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 72.7 kB | 72.8 kB |
Legacy Client Bundles (polyfills)
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.39 kB | 2.39 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 919 B | 919 B | ✓ |
image-HASH.js gzip | 4.73 kB | 4.73 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 544 B | 545 B | |
withRouter.html gzip | 525 B | 525 B | ✓ |
Overall change | 1.6 kB | 1.6 kB |
Diffs
Diff for main-HASH.js
@@ -465,7 +465,7 @@
exports.renderError = renderError;
exports.emitter = exports.router = exports.version = void 0;
__webpack_require__(400);
- var _react = _interopRequireDefault1(__webpack_require__(7294));
+ var _react = _interopRequireWildcard1(__webpack_require__(7294));
var _reactDom = _interopRequireDefault1(__webpack_require__(3935));
var _styledJsx = __webpack_require__(8771);
var _headManagerContext = __webpack_require__(8404);
@@ -486,6 +486,7 @@
var _router1 = __webpack_require__(387);
var _isError = _interopRequireDefault1(__webpack_require__(676));
var _vitals = __webpack_require__(7813);
+ var _rsc = __webpack_require__(4692);
function asyncGeneratorStep(
gen,
resolve,
@@ -1245,7 +1246,12 @@
};
var RSCComponent;
if (false) {
- var RSCWrapper, rscCache, createResponseCache;
+ var RSCWrapper,
+ getHref,
+ rscCache,
+ createFromFetch,
+ fetchFlight,
+ createResponseCache;
}
var lastAppProps;
function doRender(input) {
@@ -2746,6 +2752,28 @@
/***/
},
+ /***/ 4692: /***/ function(
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) {
+ "use strict";
+
+ Object.defineProperty(exports, "__esModule", {
+ value: true
+ });
+ exports.useRefreshRoot = useRefreshRoot;
+ exports.RefreshContext = void 0;
+ var _react = __webpack_require__(7294);
+ var RefreshContext = (0, _react).createContext(function(_) {});
+ exports.RefreshContext = RefreshContext;
+ function useRefreshRoot() {
+ return (0, _react).useContext(RefreshContext);
+ } //# sourceMappingURL=rsc.js.map
+
+ /***/
+ },
+
/***/ 699: /***/ function(
__unused_webpack_module,
exports,
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-a6d927878c4a570b.js"
+ src="/_next/static/chunks/main-f53bd6d15edae6e3.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-a6d927878c4a570b.js"
+ src="/_next/static/chunks/main-f53bd6d15edae6e3.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-a6d927878c4a570b.js"
+ src="/_next/static/chunks/main-f53bd6d15edae6e3.js"
defer=""
></script>
<script
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
buildDuration | 22.2s | 22.1s | -32ms |
buildDurationCached | 3.9s | 3.7s | -175ms |
nodeModulesSize | 351 MB | 351 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.435 | 3.54 | |
/ avg req/sec | 727.75 | 706.15 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.582 | 1.647 | |
/error-in-render avg req/sec | 1579.83 | 1518 |
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 29 kB | 29.1 kB | |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 73 kB | 73 kB |
Legacy Client Bundles (polyfills)
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.39 kB | 2.39 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 906 B | 906 B | ✓ |
image-HASH.js gzip | 4.75 kB | 4.75 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
_buildManifest.js gzip | 458 B | 458 B | ✓ |
Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary | huozhi/next.js use-refresh | Change | |
---|---|---|---|
index.html gzip | 531 B | 532 B | |
link.html gzip | 544 B | 545 B | |
withRouter.html gzip | 525 B | 526 B | |
Overall change | 1.6 kB | 1.6 kB |
Diffs
Diff for main-HASH.js
@@ -465,7 +465,7 @@
exports.renderError = renderError;
exports.emitter = exports.router = exports.version = void 0;
__webpack_require__(400);
- var _react = _interopRequireDefault1(__webpack_require__(7294));
+ var _react = _interopRequireWildcard1(__webpack_require__(7294));
var _reactDom = _interopRequireDefault1(__webpack_require__(3935));
var _styledJsx = __webpack_require__(8771);
var _headManagerContext = __webpack_require__(8404);
@@ -486,6 +486,7 @@
var _router1 = __webpack_require__(387);
var _isError = _interopRequireDefault1(__webpack_require__(676));
var _vitals = __webpack_require__(7813);
+ var _rsc = __webpack_require__(4692);
function asyncGeneratorStep(
gen,
resolve,
@@ -1245,7 +1246,12 @@
};
var RSCComponent;
if (false) {
- var RSCWrapper, rscCache, createResponseCache;
+ var RSCWrapper,
+ getHref,
+ rscCache,
+ createFromFetch,
+ fetchFlight,
+ createResponseCache;
}
var lastAppProps;
function doRender(input) {
@@ -2746,6 +2752,28 @@
/***/
},
+ /***/ 4692: /***/ function(
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) {
+ "use strict";
+
+ Object.defineProperty(exports, "__esModule", {
+ value: true
+ });
+ exports.useRefreshRoot = useRefreshRoot;
+ exports.RefreshContext = void 0;
+ var _react = __webpack_require__(7294);
+ var RefreshContext = (0, _react).createContext(function(_) {});
+ exports.RefreshContext = RefreshContext;
+ function useRefreshRoot() {
+ return (0, _react).useContext(RefreshContext);
+ } //# sourceMappingURL=rsc.js.map
+
+ /***/
+ },
+
/***/ 699: /***/ function(
__unused_webpack_module,
exports,
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-a6d927878c4a570b.js"
+ src="/_next/static/chunks/main-f53bd6d15edae6e3.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-a6d927878c4a570b.js"
+ src="/_next/static/chunks/main-f53bd6d15edae6e3.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-a6d927878c4a570b.js"
+ src="/_next/static/chunks/main-f53bd6d15edae6e3.js"
defer=""
></script>
<script
huozhi
requested review from
ijjk,
padmaia,
shuding and
timneutkens
as code owners
December 10, 2021 10:13
shuding
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as an initial implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Resolves #32332
fixes #number
contributing.md