Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile escape-string-regexp #32310

Merged
merged 6 commits into from Dec 9, 2021
Merged

Compile escape-string-regexp #32310

merged 6 commits into from Dec 9, 2021

Conversation

PizzaPete
Copy link
Contributor

@PizzaPete PizzaPete commented Dec 9, 2021

Bug

  • escape-string-regexp in packages/next/compiled/escape-string-regexp is not ES5 compiled.

Feature

  • Compiled escape-string-regexp to ES5.

Not sure if this is the correct way, otherwise I'd really like to know how to do it properly.

Fixes #32312

@PizzaPete PizzaPete marked this pull request as draft December 9, 2021 10:08
This reverts commit 8106c07.
@PizzaPete PizzaPete marked this pull request as ready for review December 9, 2021 11:28
@balazsorban44
Copy link
Member

Fixes #32312

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary PizzaPete/next.js canary Change
buildDuration 23.9s 24.1s ⚠️ +267ms
buildDurationCached 4.4s 4.3s -6ms
nodeModulesSize 351 MB 351 MB ⚠️ +15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PizzaPete/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 4.022 4.108 ⚠️ +0.09
/ avg req/sec 621.65 608.51 ⚠️ -13.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.191 2.252 ⚠️ +0.06
/error-in-render avg req/sec 1141.13 1110.26 ⚠️ -30.87
Client Bundles (main, webpack, commons)
vercel/next.js canary PizzaPete/next.js canary Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary PizzaPete/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary PizzaPete/next.js canary Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary PizzaPete/next.js canary Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary PizzaPete/next.js canary Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary PizzaPete/next.js canary Change
buildDuration 26.1s 26s -102ms
buildDurationCached 4.3s 4.3s ⚠️ +74ms
nodeModulesSize 351 MB 351 MB ⚠️ +15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PizzaPete/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.999 4.056 ⚠️ +0.06
/ avg req/sec 625.08 616.36 ⚠️ -8.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.194 2.259 ⚠️ +0.06
/error-in-render avg req/sec 1139.47 1106.83 ⚠️ -32.64
Client Bundles (main, webpack, commons)
vercel/next.js canary PizzaPete/next.js canary Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary PizzaPete/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary PizzaPete/next.js canary Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary PizzaPete/next.js canary Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary PizzaPete/next.js canary Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 932936c

@ijjk ijjk merged commit 0b1c9ec into vercel:canary Dec 9, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 & Next.js 12 version have syntax error with rewrites in next.config.js
3 participants