Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace raw-body with get-stream and bytes" #32305

Merged
merged 1 commit into from Dec 8, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Dec 8, 2021

Reverts #21915 since it cannot handle max buffer size.

See sindresorhus/get-stream#42

@ijjk
Copy link
Member

ijjk commented Dec 8, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
buildDuration 23.4s 23.4s -61ms
buildDurationCached 4s 4.1s ⚠️ +41ms
nodeModulesSize 350 MB 351 MB ⚠️ +429 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
/ failed reqs 0 0
/ total time (seconds) 4.014 3.857 -0.16
/ avg req/sec 622.78 648.11 +25.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.003 1.987 -0.02
/error-in-render avg req/sec 1248.06 1258.46 +10.4
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
buildDuration 24.9s 23.9s -996ms
buildDurationCached 4s 3.8s -198ms
nodeModulesSize 350 MB 351 MB ⚠️ +429 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
/ failed reqs 0 0
/ total time (seconds) 3.865 3.846 -0.02
/ avg req/sec 646.88 649.99 +3.11
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.997 2 0
/error-in-render avg req/sec 1251.81 1250.17 ⚠️ -1.64
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 29 kB 29 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.39 kB 2.39 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.75 kB 4.75 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-21915-get-stream Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 2cc025e

@kodiakhq kodiakhq bot merged commit 0b86bfa into canary Dec 8, 2021
@kodiakhq kodiakhq bot deleted the revert-21915-get-stream branch December 8, 2021 22:28
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants