Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build intentional Dirty AMP page #32278

Closed
ka2jun8 opened this issue Dec 8, 2021 · 1 comment · Fixed by #32345
Closed

Unable to build intentional Dirty AMP page #32278

ka2jun8 opened this issue Dec 8, 2021 · 1 comment · Fixed by #32345
Labels
bug Issue was opened via the bug report template.

Comments

@ka2jun8
Copy link
Contributor

ka2jun8 commented Dec 8, 2021

What version of Next.js are you using?

12.0.7

What version of Node.js are you using?

14.16.0

What browser are you using?

Chrome, Safari

What operating system are you using?

macOS

How are you deploying your application?

next

Describe the Bug

The following fixes have been made in 12.0.5.

#31505

This changed the warning to an error if the required components does not exist in _document.tsx.

Next.js supports AMP.
AMP also supports Invalid (dirty) AMP, like AMP Bento.

Even with Invalid AMP, we want to apply AMP validation and AMP optimization.

This could easily be achieved by changing Html to html.
This method is also introduced here (https://youtu.be/S_UttIYzKtM?t=736).

However, v12.0.5 causes an error.

Would you please take one of the following measures?

Expected Behavior

It should be able to build the next project even if Html is html.

To Reproduce

To use html instead of Html in amp valid page (export const config = {amp: true}).

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants