Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next-swc: Emit errors and add tests to next-ssg #32254

Merged
merged 4 commits into from Dec 16, 2021
Merged

next-swc: Emit errors and add tests to next-ssg #32254

merged 4 commits into from Dec 16, 2021

Conversation

hanneslund
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the type: next label Dec 7, 2021
@ijjk

This comment has been minimized.

Sign in to view
kdy1
kdy1 requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.
I found one tiny code style issue.

packages/next-swc/crates/core/src/next_ssg.rs Outdated
if !preserve {
tracing::trace!("Dropping a export specifier because it's a data identifier");
match preserve {
Ok(should_preserve) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok(false) seems better than pattern matching with an if expression.

You may need to add Ok(_) => {} branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, new commit up.

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
kdy1
kdy1 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ijjk
ijjk approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Dec 16, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
buildDuration 23.9s 23.4s -427ms
buildDurationCached 4.3s 4.4s ⚠️ +61ms
nodeModulesSize 350 MB 350 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.907 3.854 -0.05
/ avg req/sec 639.87 648.62 +8.75
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.941 2.022 ⚠️ +0.08
/error-in-render avg req/sec 1287.97 1236.48 ⚠️ -51.49
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 30.2 kB 30.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 74 kB 74 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.73 kB 4.73 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.13 kB 2.13 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
buildDuration 26s 26.2s ⚠️ +202ms
buildDurationCached 4.5s 4.3s -174ms
nodeModulesSize 350 MB 350 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.091 4.037 -0.05
/ avg req/sec 611.1 619.3 +8.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.085 2.073 -0.01
/error-in-render avg req/sec 1198.8 1205.83 +7.03
Client Bundles (main, webpack, commons)
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 30.3 kB 30.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 74.3 kB 74.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 906 B 906 B ✓
image-HASH.js gzip 4.75 kB 4.75 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.1 kB 14.1 kB ✓
Client Build Manifests
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js swc-next-ssg-errors Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 4bd7fcb

@kodiakhq kodiakhq bot merged commit b0bd0ee into vercel:canary Dec 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@hanneslund hanneslund deleted the swc-next-ssg-errors branch September 8, 2022 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@kdy1 kdy1 kdy1 approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanneslund @ijjk @kdy1