Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shake exports transform to next-swc #32253

Merged
merged 3 commits into from Dec 8, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Dec 7, 2021

Closes #31742

@ijjk

This comment has been minimized.

@padmaia padmaia requested a review from kdy1 December 7, 2021 22:54
packages/next-swc/crates/core/src/shake_exports.rs Outdated Show resolved Hide resolved
packages/next-swc/crates/core/src/shake_exports.rs Outdated Show resolved Hide resolved
@padmaia padmaia requested a review from kdy1 December 8, 2021 17:47
@ijjk
Copy link
Member

ijjk commented Dec 8, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
buildDuration 17.3s 17.5s ⚠️ +231ms
buildDurationCached 3.3s 3.3s ⚠️ +28ms
nodeModulesSize 348 MB 348 MB ⚠️ +1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
/ failed reqs 0 0
/ total time (seconds) 2.857 2.869 ⚠️ +0.01
/ avg req/sec 874.99 871.46 ⚠️ -3.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.335 1.336 0
/error-in-render avg req/sec 1873.03 1871.24 ⚠️ -1.79
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
index.html gzip 530 B 530 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
buildDuration 18.7s 18.5s -130ms
buildDurationCached 3.3s 3.3s -30ms
nodeModulesSize 348 MB 348 MB ⚠️ +1 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
/ failed reqs 0 0
/ total time (seconds) 2.872 2.859 -0.01
/ avg req/sec 870.46 874.35 +3.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.333 1.31 -0.02
/error-in-render avg req/sec 1874.84 1909.11 +34.27
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/treeshake-transform Change
index.html gzip 533 B 533 B
link.html gzip 544 B 544 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 250e812

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padmaia padmaia merged commit 0f7f332 into vercel:canary Dec 8, 2021
kdy1 added a commit to kdy1/next.js that referenced this pull request Dec 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree shaking next-swc transformation
3 participants