Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/load bindings improvements #32191

Merged
merged 16 commits into from Dec 7, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Dec 6, 2021

  • Changed the loading priority so it should be faster to load native bindings
  • Memoized loading
  • Added logging for binary packages that we attempted to load if loading fails
  • Updated failure to load swc binding to include platform/arch we attempted to load binaries for
  • Added a log to mention that the wasm build is still considered experimental
  • Added a job to run the production fixture against the wasm build

@ijjk
Copy link
Member

ijjk commented Dec 6, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
buildDuration 18.3s 18.3s -40ms
buildDurationCached 3.3s 3.3s ⚠️ +37ms
nodeModulesSize 347 MB 347 MB ⚠️ +2.71 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
/ failed reqs 0 0
/ total time (seconds) 2.945 2.947 0
/ avg req/sec 848.84 848.32 ⚠️ -0.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.368 1.398 ⚠️ +0.03
/error-in-render avg req/sec 1828.07 1788.88 ⚠️ -39.19
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
buildDuration 19.7s 19.7s -17ms
buildDurationCached 3.4s 3.4s -13ms
nodeModulesSize 347 MB 347 MB ⚠️ +2.71 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
/ failed reqs 0 0
/ total time (seconds) 3.012 2.955 -0.06
/ avg req/sec 830.12 846.01 +15.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.37 1.387 ⚠️ +0.02
/error-in-render avg req/sec 1824.88 1802.3 ⚠️ -22.58
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/load-bindings-improvements Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6ab2516

@timneutkens timneutkens merged commit 21f8c6a into vercel:canary Dec 7, 2021
@timneutkens timneutkens deleted the chore/load-bindings-improvements branch December 7, 2021 10:14
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants