Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert support for render prop in <Main /> #32184

Merged
merged 3 commits into from Dec 6, 2021

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Dec 6, 2021

Reverts support for render prop in <Main /> in Document. This was added just to support the useFlushEffect hook, but we've tweaked the design a bit, moving it to App.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Dec 6, 2021
@devknoll devknoll changed the title Revert support for render prop in <Main /> Revert support for render prop in <Main /> Dec 6, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 6, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
buildDuration 23.2s 23.2s ⚠️ +57ms
buildDurationCached 4.4s 4.2s -193ms
nodeModulesSize 347 MB 347 MB -1.98 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
/ failed reqs 0 0
/ total time (seconds) 3.927 3.82 -0.11
/ avg req/sec 636.63 654.49 +17.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.09 2.099 ⚠️ +0.01
/error-in-render avg req/sec 1196.26 1191.09 ⚠️ -5.17
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
buildDuration 25.6s 26s ⚠️ +321ms
buildDurationCached 4.1s 4.2s ⚠️ +47ms
nodeModulesSize 347 MB 347 MB -1.98 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
/ failed reqs 0 0
/ total time (seconds) 3.909 3.836 -0.07
/ avg req/sec 639.55 651.69 +12.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.125 2.113 -0.01
/error-in-render avg req/sec 1176.5 1183.04 +6.54
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-revert-main-render-prop Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 55e5998

@devknoll devknoll marked this pull request as ready for review December 6, 2021 21:17
@kodiakhq kodiakhq bot merged commit 9bcf678 into vercel:canary Dec 6, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants