New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade webpack and watchpack #32173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sokra
force-pushed
the
upgrade/webpack
branch
from
December 6, 2021 16:09
dcdd3ef
to
61ef8a6
Compare
Stats from current PRDefault Build (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
buildDuration | 18.8s | 18.8s | |
buildDurationCached | 3.5s | 3.5s | |
nodeModulesSize | 347 MB | 347 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.016 | 3.132 | |
/ avg req/sec | 828.83 | 798.22 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.433 | 1.47 | |
/error-in-render avg req/sec | 1744.1 | 1700.26 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 28.4 kB | 28.4 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 72.3 kB | 72.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 326 B | 326 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 635 B | 635 B | ✓ |
image-HASH.js gzip | 4.49 kB | 4.49 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.87 kB | 1.87 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 13.3 kB | 13.3 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
_buildManifest.js gzip | 460 B | 460 B | ✓ |
Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 544 B | 544 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
],
"/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
"/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-ff60bc61acd2698b.js"],
- "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-f207079640969086.js"],
+ "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-6f6ef1aea723bb04.js"],
"/link": ["static\u002Fchunks\u002Fpages\u002Flink-b57fa5abc6a43d15.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
Diff for image-HASH.js
@@ -191,7 +191,11 @@
"data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7";
if (false) {
}
- var VALID_LOADING_VALUES = ["lazy", "eager", undefined];
+ var VALID_LOADING_VALUES = /* unused pure expression or super */ null && [
+ "lazy",
+ "eager",
+ undefined
+ ];
var loaders = new Map([
["default", defaultLoader],
["imgix", imgixLoader],
@@ -199,7 +203,7 @@
["akamai", akamaiLoader],
["custom", customLoader]
]);
- var VALID_LAYOUT_VALUES = [
+ var VALID_LAYOUT_VALUES = /* unused pure expression or super */ null && [
"fill",
"fixed",
"intrinsic",
Diff for main-HASH.js
@@ -1407,14 +1407,7 @@
},
[callbacks]
);
- if (undefined) {
- // eslint-disable-next-line react-hooks/rules-of-hooks
- _react.default.useEffect(function() {
- window.__NEXT_HYDRATED = true;
- if (window.__NEXT_HYDRATED_CB) {
- window.__NEXT_HYDRATED_CB();
- }
- }, []);
+ if (false) {
}
// We should ask to measure the Web Vitals after rendering completes so we
// don't cause any hydration delay:
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-bae1c6f68622048e.js"
+ src="/_next/static/chunks/main-91b3f785722f4e08.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-bae1c6f68622048e.js"
+ src="/_next/static/chunks/main-91b3f785722f4e08.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-bae1c6f68622048e.js"
+ src="/_next/static/chunks/main-91b3f785722f4e08.js"
defer=""
></script>
<script
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
buildDuration | 20.3s | 20.3s | |
buildDurationCached | 3.5s | 3.5s | |
nodeModulesSize | 347 MB | 347 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.09 | 3.046 | -0.04 |
/ avg req/sec | 809.11 | 820.83 | +11.72 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.486 | 1.44 | -0.05 |
/error-in-render avg req/sec | 1682.54 | 1736.68 | +54.14 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 28.6 kB | 28.6 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 72.5 kB | 72.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 622 B | 622 B | ✓ |
image-HASH.js gzip | 4.53 kB | 4.53 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 1.9 kB | 1.9 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 13.3 kB | 13.3 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
_buildManifest.js gzip | 458 B | 458 B | ✓ |
Overall change | 458 B | 458 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js upgrade/webpack | Change | |
---|---|---|---|
index.html gzip | 530 B | 530 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 526 B | 526 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -12,7 +12,7 @@ self.__BUILD_MANIFEST = {
],
"/head": ["static\u002Fchunks\u002Fpages\u002Fhead-7100d3b2a548f0e4.js"],
"/hooks": ["static\u002Fchunks\u002Fpages\u002Fhooks-ff60bc61acd2698b.js"],
- "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-f207079640969086.js"],
+ "/image": ["static\u002Fchunks\u002Fpages\u002Fimage-6f6ef1aea723bb04.js"],
"/link": ["static\u002Fchunks\u002Fpages\u002Flink-b57fa5abc6a43d15.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-76232dd6bc335a24.js"
Diff for image-HASH.js
@@ -191,7 +191,11 @@
"data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7";
if (false) {
}
- var VALID_LOADING_VALUES = ["lazy", "eager", undefined];
+ var VALID_LOADING_VALUES = /* unused pure expression or super */ null && [
+ "lazy",
+ "eager",
+ undefined
+ ];
var loaders = new Map([
["default", defaultLoader],
["imgix", imgixLoader],
@@ -199,7 +203,7 @@
["akamai", akamaiLoader],
["custom", customLoader]
]);
- var VALID_LAYOUT_VALUES = [
+ var VALID_LAYOUT_VALUES = /* unused pure expression or super */ null && [
"fill",
"fixed",
"intrinsic",
Diff for main-HASH.js
@@ -1407,14 +1407,7 @@
},
[callbacks]
);
- if (undefined) {
- // eslint-disable-next-line react-hooks/rules-of-hooks
- _react.default.useEffect(function() {
- window.__NEXT_HYDRATED = true;
- if (window.__NEXT_HYDRATED_CB) {
- window.__NEXT_HYDRATED_CB();
- }
- }, []);
+ if (false) {
}
// We should ask to measure the Web Vitals after rendering completes so we
// don't cause any hydration delay:
Diff for index.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-bae1c6f68622048e.js"
+ src="/_next/static/chunks/main-91b3f785722f4e08.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-bae1c6f68622048e.js"
+ src="/_next/static/chunks/main-91b3f785722f4e08.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,7 +19,7 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-bae1c6f68622048e.js"
+ src="/_next/static/chunks/main-91b3f785722f4e08.js"
defer=""
></script>
<script
sokra
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
December 6, 2021 17:04
⚙ Update compiled files
sokra
force-pushed
the
upgrade/webpack
branch
from
December 14, 2021 09:00
61ef8a6
to
6b6a274
Compare
huozhi
approved these changes
Dec 14, 2021
timneutkens
approved these changes
Dec 14, 2021
cdierkens
pushed a commit
to cdierkens/next.js
that referenced
this pull request
Dec 20, 2021
Co-authored-by: sokra <sokra@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint