Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Base Server #32154

Merged
merged 1 commit into from Dec 5, 2021
Merged

Create Base Server #32154

merged 1 commit into from Dec 5, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Dec 5, 2021

Same as #32105 (closed due to conflicts):

Explained in #32066, rename next-server as base-server and extend NextNodeServer on top of it.

Note that this is just an initial PR so no method is ported.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Dec 5, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/5c10 Change
buildDuration 23.2s 23.9s ⚠️ +774ms
buildDurationCached 4.2s 4.2s -52ms
nodeModulesSize 347 MB 347 MB ⚠️ +1.84 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/5c10 Change
/ failed reqs 0 0
/ total time (seconds) 4.036 4.036
/ avg req/sec 619.41 619.44 +0.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.085 2.071 -0.01
/error-in-render avg req/sec 1199.22 1207.03 +7.81
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/5c10 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/5c10 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/5c10 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/5c10 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/5c10 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/5c10 Change
buildDuration 25.4s 25.8s ⚠️ +475ms
buildDurationCached 4.2s 4.3s ⚠️ +78ms
nodeModulesSize 347 MB 347 MB ⚠️ +1.84 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/5c10 Change
/ failed reqs 0 0
/ total time (seconds) 3.957 3.976 ⚠️ +0.02
/ avg req/sec 631.83 628.79 ⚠️ -3.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.047 2.115 ⚠️ +0.07
/error-in-render avg req/sec 1221.17 1182.09 ⚠️ -39.08
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/5c10 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/5c10 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/5c10 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/5c10 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/5c10 Change
index.html gzip 530 B 530 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 817d71c

@kodiakhq kodiakhq bot merged commit c004322 into vercel:canary Dec 5, 2021
@shuding shuding deleted the shu/5c10 branch December 5, 2021 22:27
@shuding shuding moved this from In Progress to Done in React Server Components in Next.js (Alpha) Dec 6, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants