Skip to content

Fix document type import path #32117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Dec 4, 2021

There was a mistake in #32077 which imported a different module than _document in the _document .d.ts file. I found that we didn't have a test for a custom _document.tsx and _app.tsx with TypeScript, so I've added one that fails on canary and passes with this fix to ensure this does not happen in the future.

Fixes #32110

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Sorry, something went wrong.

There was a mistake in vercel#32077 which imported a different module than _document in the _document .d.ts file. I found that we didn't have a test for a custom _document.tsx and _app.tsx with TypeScript, so I've added one that fails on canary and passes with this fix to ensure this does not happen in the future.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ijjk
Copy link
Member

ijjk commented Dec 4, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/document-type Change
buildDuration 18.1s 18.3s ⚠️ +187ms
buildDurationCached 3.4s 3.3s -22ms
nodeModulesSize 347 MB 347 MB -10 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/document-type Change
/ failed reqs 0 0
/ total time (seconds) 2.957 2.956 0
/ avg req/sec 845.36 845.77 +0.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.36 1.398 ⚠️ +0.04
/error-in-render avg req/sec 1838.43 1788.26 ⚠️ -50.17
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/document-type Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/document-type Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/document-type Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/document-type Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/document-type Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/document-type Change
buildDuration 19.8s 19.8s -4ms
buildDurationCached 3.4s 3.3s -82ms
nodeModulesSize 347 MB 347 MB -10 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/document-type Change
/ failed reqs 0 0
/ total time (seconds) 3 2.928 -0.07
/ avg req/sec 833.34 853.73 +20.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.397 1.355 -0.04
/error-in-render avg req/sec 1789.34 1844.75 +55.41
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/document-type Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/document-type Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/document-type Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/document-type Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/document-type Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 320d83a

@kodiakhq kodiakhq bot merged commit 980e169 into vercel:canary Dec 4, 2021
kachkaev added a commit to kachkaev/njt that referenced this pull request Dec 4, 2021

Verified

This commit was signed with the committer’s verified signature.
kachkaev Alexander Kachkaev
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-config-next@12.0.5 gives "Type '() => any' is not a constructor function type" error in _Document.tsx
4 participants