Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix running server with Polyfilled fetch (#31935)" #32100

Merged
merged 1 commit into from Dec 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 3, 2021

This reverts commit 1c199a5.

This seems to be causing unexpected 405 responses when deployed so reverting for now to allow investigating.

Re-opens: #30398
x-ref: #31935

@ijjk
Copy link
Member Author

ijjk commented Dec 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js revert/fetch-change Change
buildDuration 17s 16.5s -481ms
buildDurationCached 3.1s 3.5s ⚠️ +342ms
nodeModulesSize 347 MB 347 MB -5.36 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js revert/fetch-change Change
/ failed reqs 0 0
/ total time (seconds) 2.69 2.821 ⚠️ +0.13
/ avg req/sec 929.53 886.19 ⚠️ -43.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.291 1.358 ⚠️ +0.07
/error-in-render avg req/sec 1936.1 1840.93 ⚠️ -95.17
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/fetch-change Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/fetch-change Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js revert/fetch-change Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/fetch-change Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js revert/fetch-change Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js revert/fetch-change Change
buildDuration 20.6s 20.1s -486ms
buildDurationCached 3.1s 3s -56ms
nodeModulesSize 347 MB 347 MB -5.36 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js revert/fetch-change Change
/ failed reqs 0 0
/ total time (seconds) 2.871 3.084 ⚠️ +0.21
/ avg req/sec 870.92 810.55 ⚠️ -60.37
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.246 1.5 ⚠️ +0.25
/error-in-render avg req/sec 2006.6 1667.05 ⚠️ -339.55
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/fetch-change Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/fetch-change Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js revert/fetch-change Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/fetch-change Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js revert/fetch-change Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 8ccb816

@ijjk ijjk merged commit f0fd496 into vercel:canary Dec 3, 2021
@ijjk ijjk deleted the revert/fetch-change branch December 3, 2021 21:31
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants