Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure invalid URLs respond with 400 correctly #32092

Merged
merged 3 commits into from Dec 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 3, 2021

This ensures we catch any errors in handleRequest so that we can respond with a 400 for invalid requests.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Closes: #32080

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 3, 2021
@ijjk ijjk marked this pull request as ready for review December 3, 2021 16:25
@ijjk

This comment has been minimized.

timneutkens
timneutkens previously approved these changes Dec 3, 2021
@ijjk
Copy link
Member Author

ijjk commented Dec 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js handle/invalid-url Change
buildDuration 21.4s 21.6s ⚠️ +261ms
buildDurationCached 4s 4s ⚠️ +14ms
nodeModulesSize 347 MB 347 MB ⚠️ +1.01 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js handle/invalid-url Change
/ failed reqs 0 0
/ total time (seconds) 3.473 3.46 -0.01
/ avg req/sec 719.89 722.44 +2.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.553 1.599 ⚠️ +0.05
/error-in-render avg req/sec 1609.77 1563.37 ⚠️ -46.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js handle/invalid-url Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js handle/invalid-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js handle/invalid-url Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js handle/invalid-url Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js handle/invalid-url Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js handle/invalid-url Change
buildDuration 23.1s 22.7s -391ms
buildDurationCached 3.9s 3.9s -62ms
nodeModulesSize 347 MB 347 MB ⚠️ +1.01 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js handle/invalid-url Change
/ failed reqs 0 0
/ total time (seconds) 3.463 3.413 -0.05
/ avg req/sec 721.98 732.52 +10.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.595 1.553 -0.04
/error-in-render avg req/sec 1567.06 1609.9 +42.84
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js handle/invalid-url Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js handle/invalid-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js handle/invalid-url Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js handle/invalid-url Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js handle/invalid-url Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 8173374

@ijjk ijjk requested a review from timneutkens December 3, 2021 17:10
@kodiakhq kodiakhq bot merged commit 6d98b4f into vercel:canary Dec 3, 2021
@ijjk ijjk deleted the handle/invalid-url branch December 3, 2021 17:31
skooch pushed a commit to skooch/next.js that referenced this pull request Dec 16, 2021
@seve seve mentioned this pull request Jan 25, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants