Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the testall npm script #32081

Merged
merged 3 commits into from Dec 3, 2021
Merged

Fix the testall npm script #32081

merged 3 commits into from Dec 3, 2021

Conversation

chentsulin
Copy link
Contributor

yarn test has been removed by #32042, so it should be replaced by the other test scripts.

@ijjk

This comment has been minimized.

package.json Outdated
@@ -15,7 +15,7 @@
"test-unit": "yarn jest test/unit/",
"testonly": "yarn jest --runInBand",
"testheadless": "cross-env HEADLESS=true yarn testonly",
"testall": "yarn test -- --ci --forceExit && lerna run --scope @next/codemod test",
"testall": "yarn testonly && yarn testheadless && lerna run --scope @next/codemod test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is testonly and testheadless being called? Won't this run tests twice once non-headless and again headless?

Copy link
Contributor Author

@chentsulin chentsulin Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a mistake. I just removed the headless one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we are using this script anywhere, it might be good to remove it as we recommend running specific tests in the contributing doc

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary chentsulin/next.js testall Change
buildDuration 18.5s 18.4s -106ms
buildDurationCached 3.5s 3.4s -119ms
nodeModulesSize 347 MB 347 MB -14 B
Page Load Tests Overall increase ✓
vercel/next.js canary chentsulin/next.js testall Change
/ failed reqs 0 0
/ total time (seconds) 3.011 2.947 -0.06
/ avg req/sec 830.24 848.29 +18.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.339 1.329 -0.01
/error-in-render avg req/sec 1867.4 1880.52 +13.12
Client Bundles (main, webpack, commons)
vercel/next.js canary chentsulin/next.js testall Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chentsulin/next.js testall Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary chentsulin/next.js testall Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary chentsulin/next.js testall Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary chentsulin/next.js testall Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary chentsulin/next.js testall Change
buildDuration 19.9s 19.7s -235ms
buildDurationCached 3.4s 3.4s -44ms
nodeModulesSize 347 MB 347 MB -14 B
Page Load Tests Overall increase ✓
vercel/next.js canary chentsulin/next.js testall Change
/ failed reqs 0 0
/ total time (seconds) 2.98 3.001 ⚠️ +0.02
/ avg req/sec 838.84 833.13 ⚠️ -5.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.377 1.345 -0.03
/error-in-render avg req/sec 1816.19 1858.49 +42.3
Client Bundles (main, webpack, commons)
vercel/next.js canary chentsulin/next.js testall Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary chentsulin/next.js testall Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary chentsulin/next.js testall Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary chentsulin/next.js testall Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary chentsulin/next.js testall Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6464f82

@kodiakhq kodiakhq bot merged commit 3a5e424 into vercel:canary Dec 3, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants