Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TextEncoder and TextDecoder wrappers #31490

Merged
merged 2 commits into from Nov 16, 2021

Conversation

javivelasco
Copy link
Member

This PR removes the class wrapper that we have for TextEncoder and TextDecoder. Since this is merged we will be using directly the Node version in the sandbox.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
buildDuration 24.9s 25.6s ⚠️ +610ms
buildDurationCached 4.8s 4.9s ⚠️ +48ms
nodeModulesSize 336 MB 336 MB -2.06 kB
Page Load Tests Overall increase ✓
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
/ failed reqs 0 0
/ total time (seconds) 4.217 4.23 ⚠️ +0.01
/ avg req/sec 592.78 590.97 ⚠️ -1.81
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.259 2.202 -0.06
/error-in-render avg req/sec 1106.66 1135.3 +28.64
Client Bundles (main, webpack, commons)
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
buildDuration 27.3s 27.1s -182ms
buildDurationCached 5.1s 4.8s -248ms
nodeModulesSize 336 MB 336 MB -2.06 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
/ failed reqs 0 0
/ total time (seconds) 4.248 4.279 ⚠️ +0.03
/ avg req/sec 588.45 584.23 ⚠️ -4.22
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.165 2.213 ⚠️ +0.05
/error-in-render avg req/sec 1154.52 1129.44 ⚠️ -25.08
Client Bundles (main, webpack, commons)
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary javivelasco/next.js remove-text-encoder-wrapper Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 0bbb751

@kodiakhq kodiakhq bot merged commit 9375485 into vercel:canary Nov 16, 2021
@javivelasco javivelasco deleted the remove-text-encoder-wrapper branch November 19, 2021 08:40
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants