Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure swc dep is copied for isolated tests #31462

Merged
merged 1 commit into from Nov 15, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 15, 2021

This ensures the swc binary installed on the monorepo is copied when a custom built one isn't already available for the isolated Next.js tests.

x-ref: #31119 (comment)

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 15, 2021
@ijjk
Copy link
Member Author

ijjk commented Nov 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
buildDuration 21s 20.9s -107ms
buildDurationCached 4.1s 4s -66ms
nodeModulesSize 335 MB 335 MB -3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
/ failed reqs 0 0
/ total time (seconds) 3.553 3.61 ⚠️ +0.06
/ avg req/sec 703.53 692.44 ⚠️ -11.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.98 1.99 ⚠️ +0.01
/error-in-render avg req/sec 1262.63 1256.14 ⚠️ -6.49
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
buildDuration 22.7s 23s ⚠️ +292ms
buildDurationCached 4s 4s -24ms
nodeModulesSize 335 MB 335 MB -3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
/ failed reqs 0 0
/ total time (seconds) 3.607 3.627 ⚠️ +0.02
/ avg req/sec 693.09 689.21 ⚠️ -3.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.863 1.923 ⚠️ +0.06
/error-in-render avg req/sec 1341.8 1299.94 ⚠️ -41.86
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/test-binary-handling Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 2cb8c64

@ijjk ijjk marked this pull request as draft November 15, 2021 19:48
@ijjk ijjk marked this pull request as ready for review November 15, 2021 19:55
@ijjk ijjk merged commit a9eb0de into vercel:canary Nov 15, 2021
@ijjk ijjk deleted the update/test-binary-handling branch November 15, 2021 19:55
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants