Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a swc transform for removal of console.* calls. #31449

Merged
merged 6 commits into from Nov 16, 2021

Conversation

losfair
Copy link
Contributor

@losfair losfair commented Nov 15, 2021

Fixes #31332.

Adds a experimental.removeConsole config entry that allows to remove all console.* calls. Similar to babel-plugin-transform-remove-console.

Example next.config.js:

  • Suppress console output except console.error:
module.exports = {
  experimental: {
    removeConsole: {
      exclude: ['error'],
    },
  },
}
  • Suppress all console output:
module.exports = {
  experimental: {
    removeConsole: true,
  },
}

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added examples Issue/PR related to examples type: next labels Nov 15, 2021
@losfair losfair added the created-by: Next.js team PRs by the Next.js team label Nov 15, 2021
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some tiny issues.

packages/next/build/swc/src/remove_console.rs Outdated Show resolved Hide resolved
packages/next/build/swc/src/remove_console.rs Outdated Show resolved Hide resolved
packages/next/build/swc/src/remove_console.rs Outdated Show resolved Hide resolved
packages/next/build/swc/src/remove_console.rs Outdated Show resolved Hide resolved
packages/next/build/swc/src/remove_console.rs Outdated Show resolved Hide resolved
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@ijjk
Copy link
Member

ijjk commented Nov 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary losfair/next.js remove-console Change
buildDuration 23s 23.5s ⚠️ +450ms
buildDurationCached 4.7s 4.4s -278ms
nodeModulesSize 336 MB 336 MB ⚠️ +477 B
Page Load Tests Overall increase ✓
vercel/next.js canary losfair/next.js remove-console Change
/ failed reqs 0 0
/ total time (seconds) 3.858 3.882 ⚠️ +0.02
/ avg req/sec 648.02 644.02 ⚠️ -4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.19 2.035 -0.15
/error-in-render avg req/sec 1141.35 1228.36 +87.01
Client Bundles (main, webpack, commons)
vercel/next.js canary losfair/next.js remove-console Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary losfair/next.js remove-console Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary losfair/next.js remove-console Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary losfair/next.js remove-console Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary losfair/next.js remove-console Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary losfair/next.js remove-console Change
buildDuration 26.2s 25.4s -762ms
buildDurationCached 4.7s 4.6s -13ms
nodeModulesSize 336 MB 336 MB ⚠️ +477 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary losfair/next.js remove-console Change
/ failed reqs 0 0
/ total time (seconds) 3.932 3.914 -0.02
/ avg req/sec 635.86 638.76 +2.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.109 2.199 ⚠️ +0.09
/error-in-render avg req/sec 1185.18 1136.77 ⚠️ -48.41
Client Bundles (main, webpack, commons)
vercel/next.js canary losfair/next.js remove-console Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary losfair/next.js remove-console Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary losfair/next.js remove-console Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary losfair/next.js remove-console Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary losfair/next.js remove-console Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: db89be9

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @losfair 👍

@timneutkens timneutkens merged commit a39a896 into vercel:canary Nov 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port babel-plugin-transform-remove-console to SWC
4 participants