Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/i18n Do not support the second locale in the pathname #31229

Merged
merged 7 commits into from Nov 11, 2021
Merged

bugfix/i18n Do not support the second locale in the pathname #31229

merged 7 commits into from Nov 11, 2021

Conversation

vordgi
Copy link
Contributor

@vordgi vordgi commented Nov 9, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #31228

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@vordgi
Copy link
Contributor Author

vordgi commented Nov 10, 2021

fixes #31228

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you add an integration test in https://github.com/vercel/next.js/tree/canary/test/integration/i18n-support to ensure this is working properly?

@ijjk

This comment has been minimized.

@vordgi vordgi requested a review from ijjk November 10, 2021 19:08
@vordgi
Copy link
Contributor Author

vordgi commented Nov 10, 2021

Hello, done. What are the next steps? (it's my first PR here)
What should I do and what will happen with the task (the type task is still "template")?

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change and added test looks good thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Nov 11, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
buildDuration 31.3s 30s -1.3s
buildDurationCached 6.4s 6.9s ⚠️ +554ms
nodeModulesSize 334 MB 334 MB -25 B
Page Load Tests Overall increase ✓
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
/ failed reqs 0 0
/ total time (seconds) 5.491 4.356 -1.13
/ avg req/sec 455.31 573.95 +118.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 4.291 2.47 -1.82
/error-in-render avg req/sec 582.63 1012.04 +429.41
Client Bundles (main, webpack, commons)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
buildDuration 28.6s 36.6s ⚠️ +8s
buildDurationCached 8.5s 4.5s -4s
nodeModulesSize 334 MB 334 MB -25 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
/ failed reqs 0 0
/ total time (seconds) 4.996 7.452 ⚠️ +2.46
/ avg req/sec 500.38 335.47 ⚠️ -164.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.076 2.886 ⚠️ +0.81
/error-in-render avg req/sec 1204.41 866.12 ⚠️ -338.29
Client Bundles (main, webpack, commons)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vordgi/next.js bugfix/second-locale-in-pathname Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 73f7d15

@kodiakhq kodiakhq bot merged commit ae1d271 into vercel:canary Nov 11, 2021
@vordgi vordgi deleted the bugfix/second-locale-in-pathname branch November 11, 2021 07:37
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n configuration. The pathname can contain 2 different locales and it works (f.e. /en/de/).
4 participants