Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable styled-components displayName in production #31216

Merged
merged 3 commits into from Nov 9, 2021

Conversation

timneutkens
Copy link
Member

This makes more sense as a default for production given that displayName is stripped for other components too.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
buildDuration 21.1s 20.9s -166ms
buildDurationCached 4.3s 4.2s -34ms
nodeModulesSize 333 MB 333 MB ⚠️ +93 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
/ failed reqs 0 0
/ total time (seconds) 3.451 3.442 -0.01
/ avg req/sec 724.47 726.34 +1.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.629 1.611 -0.02
/error-in-render avg req/sec 1534.76 1552.04 +17.28
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
buildDuration 22.6s 22.9s ⚠️ +276ms
buildDurationCached 4.3s 4.3s -25ms
nodeModulesSize 333 MB 333 MB ⚠️ +93 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
/ failed reqs 0 0
/ total time (seconds) 3.493 3.485 -0.01
/ avg req/sec 715.81 717.33 +1.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.676 1.578 -0.1
/error-in-render avg req/sec 1491.94 1584.54 +92.6
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/disable-displayname-in-prod Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 5786fb6

@ijjk ijjk merged commit 3e8b2dc into vercel:canary Nov 9, 2021
@timneutkens timneutkens deleted the add/disable-displayname-in-prod branch November 10, 2021 09:02
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants