Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for styled-components SWC transform disabled #31214

Merged
merged 2 commits into from Nov 9, 2021
Merged

Add test for styled-components SWC transform disabled #31214

merged 2 commits into from Nov 9, 2021

Conversation

timneutkens
Copy link
Member

Ensures the transform is disabled by default.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 9, 2021
timneutkens
timneutkens commented Nov 9, 2021
View reviewed changes
packages/next/build/swc/options.js
@@ -43,10 +43,7 @@ function getBaseSWCOptions({
},
},
},
styledComponents: {
displayName: styledComponents,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True is the default, same for ssr

@timneutkens timneutkens merged commit b5b315a into vercel:canary Nov 9, 2021
@timneutkens timneutkens deleted the add/disable-styled-components-by-default branch November 9, 2021 16:18
ijjk
ijjk reviewed Nov 9, 2021
View reviewed changes
test/development/basic/styled-components-disabled.test.ts
beforeAll(async () => {
next = await createNext({
files: {
'next.config.js': new FileRef(
Copy link
Member

@ijjk ijjk Nov 9, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the next.config.js being used here? This can be provided via the nextConfig field on createNext instead which is typed.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk left review comments

@huozhi huozhi huozhi approved these changes

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @huozhi @ijjk