Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support assetPrefix specific protocol #31213

Merged
merged 3 commits into from Nov 9, 2021

Conversation

genetschneider
Copy link
Contributor

@genetschneider genetschneider commented Nov 9, 2021

This PRs takes into account the protocol of the assetPrefix if exists instead of solely relying on local browser protocol.

Fixes: #31139
Closes: #31217

@ijjk

This comment has been minimized.

@neeraj3029
Copy link
Contributor

Hey @ijjk this change would be helpful for me, if merged!
It would be great to see this in v12.0.4

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
buildDuration 21.2s 21s -168ms
buildDurationCached 4.2s 4.4s ⚠️ +245ms
nodeModulesSize 333 MB 333 MB ⚠️ +549 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
/ failed reqs 0 0
/ total time (seconds) 3.4 3.479 ⚠️ +0.08
/ avg req/sec 735.27 718.69 ⚠️ -16.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.553 1.558 ⚠️ +0.01
/error-in-render avg req/sec 1609.93 1604.31 ⚠️ -5.62
Client Bundles (main, webpack, commons)
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
index.html gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 518 B 518 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
buildDuration 22.1s 22.4s ⚠️ +248ms
buildDurationCached 4.2s 4.2s ⚠️ +97ms
nodeModulesSize 333 MB 333 MB ⚠️ +549 B
Page Load Tests Overall increase ✓
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
/ failed reqs 0 0
/ total time (seconds) 3.417 3.454 ⚠️ +0.04
/ avg req/sec 731.62 723.83 ⚠️ -7.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.656 1.638 -0.02
/error-in-render avg req/sec 1509.41 1526.17 +16.76
Client Bundles (main, webpack, commons)
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary genetschneider/next.js-1 fix-https-connections Change
index.html gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: 0e809db

@ijjk ijjk merged commit e3135cc into vercel:canary Nov 9, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants