Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse and warn for invalid sizes prop on Image component #31209

Closed
styfle opened this issue Nov 9, 2021 · 1 comment
Closed

Parse and warn for invalid sizes prop on Image component #31209

styfle opened this issue Nov 9, 2021 · 1 comment
Assignees
@styfle @atcastle
Labels
Image (next/image) Related to Next.js Image Optimization.
Milestone
backlog

Comments

@styfle
Copy link
Member

styfle commented Nov 9, 2021

As a follow up to #31064 (comment) we can use the description from the html spec to parse the sizes prop and warn if its invalid.

We probably don't want to try evaluating the media condition, just parsing the string should be sufficient.
@styfle styfle added kind: story Image (next/image) Related to Next.js Image Optimization. labels Nov 9, 2021
@styfle styfle self-assigned this Nov 9, 2021
@styfle styfle added this to the backlog milestone Nov 16, 2021
@qjoner

This comment has been minimized.

Sign in to view
@kara kara assigned atcastle and unassigned kara Jan 31, 2022
@vercel vercel locked and limited conversation to collaborators Apr 17, 2024
@balazsorban44 balazsorban44 converted this issue into discussion #64640 Apr 17, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees

@styfle styfle

@atcastle atcastle

Labels
Image (next/image) Related to Next.js Image Optimization.
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
4 participants
@styfle @kara @atcastle @qjoner